Skip to content

refactor(ramp): add routes folder#8457

Merged
wachunei merged 3 commits into
mainfrom
refactor/ramp-routes
Jan 31, 2024
Merged

refactor(ramp): add routes folder#8457
wachunei merged 3 commits into
mainfrom
refactor/ramp-routes

Conversation

@wachunei

@wachunei wachunei commented Jan 29, 2024

Copy link
Copy Markdown
Member

Description

This PR adds a routes folder inside Ramp experience folder. Related to this channel and effort :https://consensys.slack.com/archives/C062YJBAAEA/p1706108478487099

Related issues

Fixes:

Manual testing steps

Navigating to Ramp experiences must have no impact.

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@wachunei wachunei added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-money-movement issues related to Money Movement features needs-money-movement-qa Tickets that need feature QA on the ramps flows labels Jan 29, 2024
@wachunei wachunei marked this pull request as ready for review January 29, 2024 23:11
@wachunei wachunei requested a review from a team as a code owner January 29, 2024 23:11
@github-actions

github-actions Bot commented Jan 29, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/c5197b52-eb6d-480a-9cb8-5e1ab237d448
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@github-actions

github-actions Bot commented Jan 30, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Cal-L
Cal-L approved these changes Jan 30, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@codecov-commenter

codecov-commenter commented Jan 30, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

Attention: 3 lines in your changes are missing coverage. Please review.

Comparison is base (4dd9073) 40.62% compared to head (b36efe4) 40.62%.

Files Patch % Lines
app/components/Nav/Main/MainNavigator.js 0.00% 2 Missing ⚠️
app/components/UI/Ramp/routes/index.tsx 66.66% 1 Missing ⚠️
Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8457   +/-   ##
=======================================
  Coverage   40.62%   40.62%           
=======================================
  Files        1239     1240    +1     
  Lines       29989    29989           
  Branches     2870     2870           
=======================================
  Hits        12182    12182           
  Misses      17109    17109           
  Partials      698      698

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@wachunei wachunei removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 30, 2024
@sonarqubecloud

sonarqubecloud Bot commented Jan 31, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
40.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarCloud

@bkirb

bkirb commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

@wachunei LGTM I finished verifying ✅

@wachunei wachunei added money-movement-qa-passed and removed needs-money-movement-qa Tickets that need feature QA on the ramps flows labels Jan 31, 2024
@wachunei wachunei merged commit 15d5fdc into main Jan 31, 2024
@wachunei wachunei deleted the refactor/ramp-routes branch January 31, 2024 14:59
@github-actions github-actions Bot locked and limited conversation to collaborators Jan 31, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

money-movement-qa-passed release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-money-movement issues related to Money Movement features

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@wachunei @codecov-commenter @bkirb @Cal-L @metamaskbot