Skip to content

feat: Enable token detection on arbitrum, optimism, base, and zksync#8392

Merged
bergeron merged 3 commits into
mainfrom
brian/token-detection
Feb 2, 2024
Merged

feat: Enable token detection on arbitrum, optimism, base, and zksync#8392
bergeron merged 3 commits into
mainfrom
brian/token-detection

Conversation

@bergeron

@bergeron bergeron commented Jan 25, 2024 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Enables token detection on arbitrum, optimism, base, and zksync.

Patching these from core:

Related issues

Manual testing steps

  1. Restore an account with tokens on arbitrum, optimism, base, and zksync.
  2. enable token detection in settings
  3. Switch to each of those chains
  4. It should suggest new token(s) found in this account
  5. When manually importing a token, there should be a "search" tab

Screenshots/Recordings

Before

Screen.Recording.2024-01-24.at.8.12.11.PM.mov

After

Screen.Recording.2024-01-24.at.8.26.30.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@bergeron bergeron requested a review from a team as a code owner January 25, 2024 04:29
@github-actions

github-actions Bot commented Jan 25, 2024

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bergeron bergeron changed the title Enable token detection on arbitrum, optimism, base, and zksync feat: Enable token detection on arbitrum, optimism, base, and zksync Jan 25, 2024
@codecov-commenter

codecov-commenter commented Jan 29, 2024 •
edited
Loading

Copy link
Copy Markdown

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (dbd1deb) 40.67% compared to head (83232f7) 40.67%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #8392   +/-   ##
=======================================
  Coverage   40.67%   40.67%           
=======================================
  Files        1240     1240           
  Lines       30012    30012           
  Branches     2871     2871           
=======================================
  Hits        12206    12206           
  Misses      17107    17107           
  Partials      699      699

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@bergeron bergeron added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 30, 2024
@bergeron bergeron added the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Jan 31, 2024
@salimtb

salimtb commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

were the modifications made on the core repo as well ? for good practice and history reasons, when you have the core PR please, paste it into the PR description.
It shouldn't be merged if you do not have the core PR created

@bergeron

bergeron commented Jan 31, 2024

Copy link
Copy Markdown
Contributor Author

were the modifications made on the core repo as well ? for good practice and history reasons, when you have the core PR please, paste it into the PR description. It shouldn't be merged if you do not have the core PR created

Added to description: MetaMask/core#2035, MetaMask/core#3584

@github-actions

github-actions Bot commented Jan 31, 2024

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/e7d13d68-2d44-4406-9fb7-1be7e7f2fae7
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

Cal-L
Cal-L approved these changes Feb 1, 2024
View reviewed changes

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice - LGTM!

@sonarqubecloud

sonarqubecloud Bot commented Feb 1, 2024

Copy link
Copy Markdown

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@gauthierpetetin gauthierpetetin added the team-mobile-ux Mobile UX team label Feb 2, 2024
@bergeron bergeron removed the needs-qa Any New Features that needs a full manual QA prior to being added to a release. label Feb 2, 2024
@bergeron bergeron merged commit 0b5d647 into main Feb 2, 2024
@bergeron bergeron deleted the brian/token-detection branch February 2, 2024 16:22
@github-actions github-actions Bot locked and limited conversation to collaborators Feb 2, 2024
@github-actions github-actions Bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Feb 2, 2024
@metamaskbot metamaskbot added the release-7.17.0 Issue or pull request that will be included in release 7.17.0 label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Cal-L Cal-L Cal-L approved these changes

@sahar-fehri sahar-fehri sahar-fehri approved these changes

Assignees

No one assigned

Labels

release-7.17.0 Issue or pull request that will be included in release 7.17.0 team-assets team-mobile-ux Mobile UX team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

7 participants

@bergeron @codecov-commenter @salimtb @Cal-L @sahar-fehri @gauthierpetetin @metamaskbot