feat: Update network controller v^10#8370
Merged
Merged
Conversation
…r gas fee controller, replace breaking changes on network controller and a migration for it, NetworkChainId to chainId on controller-utils
…tches for controller utils and assets-controllers, changed on new missing plances rpcTarget for rpcUrl, upgraded controller utils to v4
…onverting the chainId on that state for hexadecimal
… toggles on security and privacy settings
Fix chain ID middleware.
…st on networks constants for hexadecimal format
…Switch and some on Engine file
…h_chainId, also removed a type on test file of rpcMethodMiddleware
tommasini
commented
Jan 31, 2024
Contributor
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/82be4116-01bd-4480-b2b5-5c7188f89c88 |
georgewrmarshall
approved these changes
Feb 14, 2024
georgewrmarshall
left a comment
Contributor
There was a problem hiding this comment.
Approving as code owner to unblock merge but have not tested this in any way. Please get another review from an engineer with context of these changes
|
Contributor
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bbedbdbe-ca58-4495-9bbe-6fbbb89020bf |
MarioAslau
approved these changes
Feb 14, 2024
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
7 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This PR aims to update network controller to version ^10.0.0 as part of the controllers upgrade to version v55
This PR also removes the existing patch, since it's no longer needed.
Also, it updates the assert package, because couldn't find
notStrictEqualon the old version.This PR is blocked until the v53 last PR is merged, will be a draft until then
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
https://recordit.co/Mrnu9csKXG - Adding, Switching and removing network between networks on the popular list
https://recordit.co/Bmhhi1eOeG - Adding and Switching network from Dapps and Import it custom manually
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist
CI Related Section: DO NOT EDIT
Flag used by Bitrise to either run or skip E2E smoke tests