Description

When displaying a personal sign confirmation, the extension displays data with a length of 32 bytes as the original hexadecimal string, rather than the utf8 equivalent. This is likely to acommodate cases where a hash is to be signed rather than a human readable message.

Mobile always displays the utf8 equivalent which results in invalid characters if a hash was provided.

See extension code here.

Related issues

Fixes:

Manual testing steps

1. Perform personal_sign request with the first argument (data) as a 32 byte hexadecimal string.
2. Ensure same string is visible in the confirmation.
3. Perform personal_sign with any other buffer size.
4. Ensure equivalent UTF8 is displayed.

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I’ve followed MetaMask Coding Standards.
• I've clearly explained what problem this PR is solving and how it is solved.
• I've linked related issues
• I've included manual testing steps
• I've included screenshots/recordings if applicable
• I’ve included tests if applicable
• I’ve documented my code using JSDoc format if applicable
• I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
• I’ve properly set the pull request status:
  • In case it's not yet "ready for review", I've set it to "draft".
  • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.