fix: Update navigation bar on start loading#8126
Conversation
… and do it when loading starts, also disconnect the bridge when load starts and verify immediately if the url is allowed or not, only after address updating the navigation bar if the url it is different from the previous one, removing than the update of the navigation bar only on load ends
…f react native webview
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov ReportAttention:
Additional details and impacted files@@ Coverage Diff @@
## main #8126 +/- ##
=======================================
Coverage 40.67% 40.67%
=======================================
Files 1240 1240
Lines 30012 30009 -3
Branches 2871 2871
=======================================
Hits 12206 12206
+ Misses 17107 17104 -3
Partials 699 699 ☔ View full report in Codecov by Sentry. |
|
|
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/85fee0bc-76ba-450f-b718-83b16f54ac17 |
Description
This PR aims to change the navigation bar to update when the loading starts and remove it from updating it when the loading ends.
Keeping onLoad because it seems some users still need a work around to get it work, and I have unknown data that shows me that this bug is not currently happening, and doing the patch does not seem the best option at the moment. We should check if this is still a bug on the newest versions of react native webview code.
Related issues
More details here
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist