Skip to content

fix: temp disable SES#8045

Closed
leotm wants to merge 3 commits into
mainfrom
fix/unbreak-ci-temp-disable-ses
Closed

fix: temp disable SES#8045
leotm wants to merge 3 commits into
mainfrom
fix/unbreak-ci-temp-disable-ses

Conversation

@leotm

@leotm leotm commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

Description

Temporarily disable lockdown to unbreak CI
after investigation the CI unit test failures are unrelated to SES #8046

Temporarily disable lockdown to fix recent spike in iOS crashes.
The fix is here: #8033
But CI is currently down to verify the fix, so we may want to merge this now instead

Related issues

Fixes:

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@leotm leotm requested a review from a team as a code owner December 7, 2023 22:36
@github-actions

github-actions Bot commented Dec 7, 2023

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@leotm leotm marked this pull request as draft December 7, 2023 22:44
@leotm

leotm commented Dec 7, 2023

Copy link
Copy Markdown
Contributor Author

converted back to draft as unit tests still failing

appears unrelated to SES lockdown, but won't close this PR just yet pending further investigation

@leotm

leotm commented Dec 7, 2023

Copy link
Copy Markdown
Contributor Author

closing for now as appears related to our Jest and Node version

rather than SES lockdown

@leotm leotm closed this Dec 7, 2023
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 7, 2023
@leotm leotm changed the title fix: temp disable SES to unbreak CI fix: temp disable SES Dec 7, 2023
@leotm leotm reopened this Dec 7, 2023
@leotm

leotm commented Dec 14, 2023

Copy link
Copy Markdown
Contributor Author

closing as hotfix went in (v7.12.2)

follow-up is here

@leotm leotm closed this Dec 14, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant