fix: temp disable SES#8045
Closed
leotm wants to merge 3 commits into
Closed
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Author
|
converted back to draft as unit tests still failing appears unrelated to SES lockdown, but won't close this PR just yet pending further investigation |
Contributor
Author
|
closing for now as appears related to our Jest and Node version rather than SES lockdown |
This reverts commit c31cf25.
Contributor
Author
|
closing as hotfix went in (v7.12.2) follow-up is here |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Temporarily disable lockdown to unbreak CIafter investigation the CI unit test failures are unrelated to SES #8046
Temporarily disable lockdown to fix recent spike in iOS crashes.
The fix is here: #8033
But CI is currently down to verify the fix, so we may want to merge this now insteadRelated issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist