Skip to content

fix: blockaid banner fix for signature requests - warning should not disappear after checking message details#7815

Merged
jpuri merged 2 commits intomainfrom
blockaid_banner_sign_fix
Nov 15, 2023
Merged

fix: blockaid banner fix for signature requests - warning should not disappear after checking message details#7815
jpuri merged 2 commits intomainfrom
blockaid_banner_sign_fix

Conversation

@jpuri
Copy link
Copy Markdown
Contributor

@jpuri jpuri commented Nov 15, 2023

Description

Blockaid banner fix for signature requests - warning should not disappear after checking message details.

Related issues

Fixes: #7804

Manual testing steps

  1. Go to test dapp
  2. Submit a malicious signature request
  3. Warning from blockaid appears
  4. Go to message details and navigate back
  5. Warning should not disappear

Screenshots/Recordings

Screen.Recording.2023-11-15.at.1.32.50.PM.mov

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@jpuri jpuri added needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) team-confirmations-secure-ux-PR PR from the confirmations team labels Nov 15, 2023
@jpuri jpuri requested a review from a team as a code owner November 15, 2023 08:04
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Nov 15, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@codecov-commenter
Copy link
Copy Markdown

codecov-commenter commented Nov 15, 2023 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Comparison is base (b29fa7e) 35.08% compared to head (fb327fe) 35.08%.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #7815   +/-   ##
=======================================
  Coverage   35.08%   35.08%           
=======================================
  Files        1039     1039           
  Lines       27628    27629    +1     
  Branches     2336     2336           
=======================================
+ Hits         9693     9694    +1     
  Misses      17412    17412           
  Partials      523      523

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@sonarqubecloud
Copy link
Copy Markdown

sonarqubecloud bot commented Nov 15, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

100.0% 100.0% Coverage
0.0% 0.0% Duplication

@jpuri
Copy link
Copy Markdown
Contributor Author

jpuri commented Nov 15, 2023

Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/04b46fe0-9d1f-411b-b801-4b85ab9441eb

segun
segun reviewed Nov 15, 2023
View reviewed changes
@jpuri jpuri merged commit fe361cc into main Nov 15, 2023
@jpuri jpuri deleted the blockaid_banner_sign_fix branch November 15, 2023 13:33
@github-actions github-actions bot locked and limited conversation to collaborators Nov 15, 2023
@github-actions github-actions bot removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Nov 15, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cryptotavares cryptotavares cryptotavares approved these changes

+2 more reviewers

@segun segun segun left review comments

@blackdevelopa blackdevelopa blackdevelopa approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

[Bug]: PPOM - Warning disappears for Signatures after checking Signature Details

6 participants

@jpuri @codecov-commenter @segun @cryptotavares @blackdevelopa @metamaskbot