chore: Cherry pick - bump axios (#7758)#7783
Conversation
## **Description** Fix CI failing on Improved Yarn Audit step ```console metamask@7.10.0 /Users/leo/Documents/GitHub/metamask-mobile ├─┬ @consensys/on-ramp-sdk@1.23.0 │ └── axios@0.27.2 ├─┬ appium-adb@9.14.11 │ └─┬ @appium/support@4.1.6 │ └── axios@1.4.0 ├─┬ appium@1.22.3 │ ├─┬ appium-android-driver@4.54.0 │ │ ├─┬ appium-chromedriver@4.28.0 │ │ │ └── axios@0.27.2 │ │ └── axios@0.27.2 │ ├─┬ appium-base-driver@7.11.3 │ │ └── axios@0.27.2 │ ├─┬ appium-ios-driver@4.8.3 │ │ └── axios@0.27.2 │ ├─┬ appium-mac2-driver@0.14.1 │ │ └── axios@0.27.2 │ ├─┬ appium-support@2.55.0 │ │ └── axios@0.27.2 │ ├─┬ appium-uiautomator2-driver@1.75.0 │ │ └── axios@0.27.2 │ ├─┬ appium-xcuitest-driver@3.62.0 │ │ └─┬ appium-webdriveragent@3.17.0 │ │ └── axios@0.27.2 │ └── axios@0.27.2 ├── axios@0.26.1 └─┬ chromedriver@99.0.0 └── axios@0.24.0 ``` <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> ## **Related issues** - CI broken past few hrs on Improved Yarn Audit step - GHSA-wf5p-g6vw-rhxx - #7747 worth looking at after ## **Manual testing steps** ```bash yarn audit:ci ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** ```console Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx Vulnerability Found: Severity: MODERATE Modules: @consensys/on-ramp-sdk>axios, appium-adb>@appium/support>axios, axios URL: GHSA-wf5p-g6vw-rhxx ``` ```console Vulnerability Found: Severity: MODERATE Modules: axios URL: GHSA-wf5p-g6vw-rhxx ``` ### **After** ```console ➜ metamask-mobile git:(fix/unbreak-ci-audit-fix-CVE-2023-45857) ✗ yarn audit:ci yarn run v1.22.19 warning ../package.json: No license field $ ./scripts/yarn-audit.sh warning ../package.json: No license field $ /Users/leo/Documents/GitHub/metamask-mobile/node_modules/.bin/improved-yarn-audit --ignore-dev-deps --min-severity moderate --fail-on-missing-exclusions Improved Yarn Audit - v3.0.0 Reading excluded advisories from .iyarc Minimum severity level to report: moderate Excluded Advisories: ["GHSA-p8p7-x288-28g6","GHSA-c2qf-rxjj-qqgw"] Running yarn audit... Found 0 vulnerabilities 2 ignored because they are dev dependencies 6 ignored because of advisory exclusions Run `yarn audit` for more information ✔ Audit shows _zero_ moderate or high severity advisories _in the production dependencies_ ✨ Done in 2.32s. ```
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
|
E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/246f58a9-22ff-45da-97c0-0f66204a29bb |
|
Updated dependencies detected. Learn more about Socket for GitHub ↗︎
|
|
👍 Dependency issues cleared. Learn more about Socket for GitHub ↗︎ This PR previously contained dependency changes with security issues that have been resolved, removed, or ignored. Ignoring: Next stepsTake a deeper look at the dependencyTake a moment to review the security alert above. Review the linked package source code to understand the potential risk. Ensure the package is not malicious before proceeding. If you're unsure how to proceed, reach out to your security team or ask the Socket team for help at support [AT] socket [DOT] dev. Remove the packageIf you happen to install a dependency that Socket reports as Known Malware you should immediately remove it and select a different dependency. For other alert types, you may may wish to investigate alternative packages or consider if there are other ways to mitigate the specific risk posed by the dependency. Mark a package as acceptable riskTo ignore an alert, reply with a comment starting with |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## release/7.11.0 #7783 +/- ##
==================================================
+ Coverage 34.97% 34.99% +0.01%
==================================================
Files 1034 1034
Lines 27529 27548 +19
Branches 2298 2284 -14
==================================================
+ Hits 9629 9641 +12
- Misses 17387 17396 +9
+ Partials 513 511 -2 ☔ View full report in Codecov by Sentry. |
|
Kudos, SonarCloud Quality Gate passed! |
|
@SocketSecurity ignore axios@1.6.0 |








Description
Fix CI failing on Improved Yarn Audit step
Related issues
Manual testing steps
Screenshots/Recordings
Before
After
Description
Related issues
Fixes: #
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Pre-merge reviewer checklist