Skip to content

docs: Update docs with new envar METAMASK_ENVIRONMENT#7756

Merged
seaona merged 1 commit into
mainfrom
doc-environment
Nov 10, 2023
Merged

docs: Update docs with new envar METAMASK_ENVIRONMENT#7756
seaona merged 1 commit into
mainfrom
doc-environment

Conversation

@seaona

@seaona seaona commented Nov 10, 2023 •
edited
Loading

Copy link
Copy Markdown
Member

Description

  • Updates the documentation and js.env.example file with the new variable METAMASK_ENVIRONMENT.
  • Adds a small note on the README.md with instructions for updating envars

Related issues

Fixes: #

Manual testing steps

Not applicable

Screenshots/Recordings

Before

Not applicable

After

Not applicable

Pre-merge author checklist

  • I’ve followed MetaMask Coding Standards.
  • I've clearly explained what problem this PR is solving and how it is solved.
  • I've linked related issues
  • I've included manual testing steps
  • I've included screenshots/recordings if applicable
  • I’ve included tests if applicable
  • I’ve documented my code using JSDoc format if applicable
  • I’ve applied the right labels on the PR (see labeling guidelines). Not required for external contributors.
  • I’ve properly set the pull request status:
    • In case it's not yet "ready for review", I've set it to "draft".
    • In case it's "ready for review", I've changed it from "draft" to "non-draft".

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@seaona seaona added the team-confirmations-secure-ux-PR PR from the confirmations team label Nov 10, 2023
@github-actions

github-actions Bot commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@seaona seaona added No QA Needed Apply this label when your PR does not need any QA effort. area-documentation labels Nov 10, 2023
@seaona seaona changed the title doc: Update docs with new envar METAMASK_ENVIRONMENT docs: Update docs with new envar METAMASK_ENVIRONMENT Nov 10, 2023
@seaona seaona marked this pull request as ready for review November 10, 2023 09:20
@seaona seaona requested a review from a team as a code owner November 10, 2023 09:20
@github-actions

github-actions Bot commented Nov 10, 2023

Copy link
Copy Markdown
Contributor

E2E test started on Bitrise: https://app.bitrise.io/app/be69d4368ee7e86d/pipelines/bccf85db-fa0e-4b09-b16c-045cf998071c
You can also kick off another Bitrise E2E smoke test by removing and re-applying the (Run Smoke E2E) label

@sonarqubecloud

sonarqubecloud Bot commented Nov 10, 2023

Copy link
Copy Markdown

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

Andepande
Andepande reviewed Nov 10, 2023
View reviewed changes

@Andepande Andepande left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@seaona seaona merged commit 8b1746a into main Nov 10, 2023
@seaona seaona deleted the doc-environment branch November 10, 2023 12:58
@github-actions github-actions Bot locked and limited conversation to collaborators Nov 10, 2023
@metamaskbot metamaskbot added the release-7.12.0 Issue or pull request that will be included in release 7.12.0 label Nov 10, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@blackdevelopa blackdevelopa blackdevelopa approved these changes

@Andepande Andepande Andepande approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

area-documentation No QA Needed Apply this label when your PR does not need any QA effort. release-7.12.0 Issue or pull request that will be included in release 7.12.0 team-confirmations-secure-ux-PR PR from the confirmations team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@seaona @blackdevelopa @Andepande @metamaskbot