docs: add JSDoc to deprecate Alert in favor of BannerAlert#6904
Closed
Libens-bufo wants to merge 3 commits intoMetaMask:mainfrom
Closed
docs: add JSDoc to deprecate Alert in favor of BannerAlert#6904Libens-bufo wants to merge 3 commits intoMetaMask:mainfrom
Libens-bufo wants to merge 3 commits intoMetaMask:mainfrom
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
Author
|
I have read the CLA Document and I hereby sign the CLA |
4524f80 to
6d37427
Compare
georgewrmarshall
approved these changes
Jul 26, 2023
Contributor
georgewrmarshall
left a comment
There was a problem hiding this comment.
LGTM! Thanks for your contribution @Libens-bufo
- pulled branch and checked deprecation identifiers and notice ✅
Contributor
|
Hey @Libens-bufo, we recently updated SonarCloud settings so external contributor PRs would pass but I think you may have to close this PR and create a new one. Would you mind doing that and we should be able to get this in |
Contributor
Author
|
Closing and creating a new one. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
Added deprecation JSDoc to deprecated code in Alert.tsx
Screenshots/Recordings
Issue
#6890 Deprecate Alert in favor of BannerAlert
Checklist