On-ramp: Add accessibility label to custom action images#6016
Merged
Conversation
Fatxx
reviewed
Mar 22, 2023
app/components/UI/FiatOnRampAggregator/components/CustomActionButton.tsx
Show resolved
Hide resolved
Fatxx
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
This PRs add an accessibility label to the images used in buttons for some providers. The issue we were facing was screen readers were reading "Buy With" instead of "Buy With < image label >".
An SDK patch version bump is needed which includes the
labeltype update.Screenshots/Recordings
If applicable, add screenshots and/or recordings to visualize the before and after of your changeIssue
Progresses #???
Checklist