Skip to content

Ignore e2e test artifacts#5998

Merged
Gudahtt merged 1 commit intomainfrom
ignore-e2e-test-artifacts
Mar 21, 2023
Merged

Ignore e2e test artifacts#5998
Gudahtt merged 1 commit intomainfrom
ignore-e2e-test-artifacts

Conversation

@Gudahtt
Copy link
Copy Markdown
Member

@Gudahtt Gudahtt commented Mar 20, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

A .gitignore entry has been added for the artifacts directory that gets generated locally when a Detox iOS e2e test fails.

Issue

No related issue. This just makes local Detox e2e tests easier to work with.

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

A `.gitignore` entry has been added for the `artifacts` directory that
gets generated locally when a Detox iOS e2e test fails.
@Gudahtt Gudahtt marked this pull request as ready for review March 20, 2023 14:16
@Gudahtt Gudahtt requested a review from a team as a code owner March 20, 2023 14:16
@Gudahtt Gudahtt added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 20, 2023
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@Cal-L Cal-L added release-6.3.0 Issue or pull request that will be included in release 6.3.0 and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 21, 2023
@Gudahtt Gudahtt merged commit 5533d89 into main Mar 21, 2023
@Gudahtt Gudahtt deleted the ignore-e2e-test-artifacts branch March 21, 2023 20:09
@github-actions github-actions bot locked and limited conversation to collaborators Mar 21, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-6.3.0 Issue or pull request that will be included in release 6.3.0

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants