Skip to content

[UPDATE] - patch for request 2.88.2 yarn audit#5988

Merged
sethkfman merged 4 commits intorelease/6.2.0from
update/patch-for-request-2.88.2-yarn-audit
Mar 17, 2023
Merged

[UPDATE] - patch for request 2.88.2 yarn audit#5988
sethkfman merged 4 commits intorelease/6.2.0from
update/patch-for-request-2.88.2-yarn-audit

Conversation

@sethkfman
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman commented Mar 17, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Provided a patch to the request dependency that addresses the yarn audit consideration.

This is adding a variable to allow opts to override and allow insecure redirects. Modeling this after PR: MetaMask/metamask-extension#18200

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@sethkfman sethkfman requested a review from a team as a code owner March 17, 2023 18:24
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Copy link
Copy Markdown
Member

@Gudahtt Gudahtt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman merged commit 24681fe into release/6.2.0 Mar 17, 2023
@sethkfman sethkfman deleted the update/patch-for-request-2.88.2-yarn-audit branch March 17, 2023 19:01
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants