Skip to content

Revert Relative Path for EditGas#5973

Merged
Cal-L merged 2 commits intorelease/6.2.0from
rc_blocker_approve
Mar 17, 2023
Merged

Revert Relative Path for EditGas#5973
Cal-L merged 2 commits intorelease/6.2.0from
rc_blocker_approve

Conversation

@blackdevelopa
Copy link
Copy Markdown
Contributor

@blackdevelopa blackdevelopa commented Mar 16, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
Revert relative path for gas modal for approve transaction. Fixes #719

Screenshots/Recordings
http://recordit.co/JwkaNlx5ze

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/719

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@blackdevelopa blackdevelopa requested a review from a team as a code owner March 16, 2023 10:20
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 16, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

blackdevelopa
blackdevelopa commented Mar 16, 2023
View reviewed changes
blackdevelopa
blackdevelopa commented Mar 16, 2023
View reviewed changes
@blackdevelopa blackdevelopa added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 16, 2023
Cal-L
Cal-L approved these changes Mar 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@Cal-L Cal-L added regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead release-6.2.0 Issue or pull request that will be included in release 6.2.0 type-bug Something isn't working labels Mar 16, 2023
@seaona
Copy link
Copy Markdown
Member

seaona commented Mar 16, 2023

QA'd the changes and looks that the issue is fixed.

  • Edit Gas fees for external dapp transactions is now working fine
  • Edit Gas fees for internal transactions is working fine
mobile-edit-gas.mp4

Cal-L
Cal-L approved these changes Mar 16, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch. changes LGTM. Looks like we have an audit issue though. Let's find a way to address that

Edit: I've rebased and this should be fixed.

@Cal-L Cal-L removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 17, 2023
@blackdevelopa
Copy link
Copy Markdown
Contributor Author

blackdevelopa commented Mar 17, 2023

@sethkfman has a PR for the failing audit, here. We can cherrypick after merge to main.

@Cal-L Cal-L force-pushed the rc_blocker_approve branch from ebaf499 to 40c8056 Compare March 17, 2023 17:59
@Cal-L Cal-L merged commit 82339c8 into release/6.2.0 Mar 17, 2023
@Cal-L Cal-L deleted the rc_blocker_approve branch March 17, 2023 18:13
@github-actions github-actions bot locked and limited conversation to collaborators Mar 17, 2023
@cryptotavares cryptotavares added team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead and removed team-confirmations-system-deprecated DEPRECATED: please use "team-confirmations" instead labels Mar 21, 2023
@chrisleewilcox chrisleewilcox removed the regression-RC DEPRECATED: Please use "regresssion-RC-x.y.z" label instead label May 23, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@jpuri jpuri jpuri approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

release-6.2.0 Issue or pull request that will be included in release 6.2.0 team-confirmations-secure-ux-deprecated DEPRECATED: please use "team-confirmations" instead type-bug Something isn't working

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

6 participants

@blackdevelopa @seaona @jpuri @Cal-L @chrisleewilcox @cryptotavares