Skip to content

[UPDATE] sonar action configuration#5972

Merged
sethkfman merged 10 commits intomainfrom
update/sonar-action-bump-checkout-action
Mar 15, 2023
Merged

[UPDATE] sonar action configuration#5972
sethkfman merged 10 commits intomainfrom
update/sonar-action-bump-checkout-action

Conversation

@sethkfman
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman commented Mar 15, 2023 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

The sonar build action needed configuration updates after it ran

  • Updated checkout action to remove node version warning in action
  • Added configs for the project analysis
             -Dsonar.javascript.lcov.reportPaths=tests/coverage/lcov.info
             -Dsonar.exclusions=android/,ios/,storybook/,sources/,scripts/,e2e/,wdio/
             -Dsonar.tests=app/
             -Dsonar.test.inclusions=**/*.test.*

Screenshots/Recordings

NA

Issue

NA

Checklist

  • [NA] There is a related GitHub issue
  • [NA] Tests are included if applicable
  • [NA] Any added code is fully documented

@sethkfman sethkfman requested a review from a team as a code owner March 15, 2023 21:49
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 15, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman sethkfman added the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Mar 15, 2023
Cal-L
Cal-L approved these changes Mar 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

Gudahtt
Gudahtt reviewed Mar 15, 2023
View reviewed changes
@sethkfman sethkfman added No QA Needed Apply this label when your PR does not need any QA effort. and removed needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Mar 15, 2023
@sethkfman sethkfman merged commit 0441bd3 into main Mar 15, 2023
@sethkfman sethkfman deleted the update/sonar-action-bump-checkout-action branch March 15, 2023 22:40
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Gudahtt Gudahtt Gudahtt approved these changes

@Cal-L Cal-L Cal-L approved these changes

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sethkfman @Gudahtt @Cal-L