Skip to content

feat: add consensys zkevm (Linea) support#5958

Merged
chrisleewilcox merged 7 commits intoMetaMask:mainfrom
VGau:feat/consensys-zkevm-support
Mar 23, 2023
Merged

feat: add consensys zkevm (Linea) support#5958
chrisleewilcox merged 7 commits intoMetaMask:mainfrom
VGau:feat/consensys-zkevm-support

Conversation

@VGau
Copy link
Copy Markdown
Contributor

@VGau VGau commented Mar 13, 2023

=======

Description
Add support for ConsenSys zkEVM network (Linea).

Screenshots/Recordings
Screenshot 2023-03-15 at 2 00 32 PM

eIgxgsEs8w.mp4

Acceptance Criteria

Manual Testing Steps

Step 1:
Go to this website: https://bridge.goerli.zkevm.consensys.net/send?token=ETH and send some ETH (minimum 0.1) from Goerli to Consensys zkEVM (Linea) .
Screenshot 2023-02-23 at 12 04 31 PM

Wait for transaction to be finished.

Step 2:
Open the metamask mobile app and select then new ConsenSys zkEVM (Linea) test network in the dropdown.
Screenshot 2023-03-15 at 2 00 32 PM

Step 3:
Go to this website: https://bridge.goerli.zkevm.consensys.net/send?token=ETH and send some ETH (minimum 0.1) from Consensys zkEVM (Linea) to Goerli.
Screenshot 2023-02-23 at 12 07 30 PM

Wait for transaction to be finished.

Final step:
Check if all transactions succeed on Metamask.

  • What Dapps does it support?

Related Tickets
Core PR (MetaMask/core#1126) to follow

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@VGau VGau requested a review from a team as a code owner March 13, 2023 17:06
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 13, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@VGau
Copy link
Copy Markdown
Contributor Author

VGau commented Mar 13, 2023

I have read the CLA Document and I hereby sign the CLA

@VGau VGau changed the title feat: add consensys zkevm support feat: add consensys zkevm (Linea) support Mar 14, 2023
@VGau VGau force-pushed the feat/consensys-zkevm-support branch 2 times, most recently from fa6cd97 to cd3f27f Compare March 17, 2023 17:19
@VGau VGau force-pushed the feat/consensys-zkevm-support branch from cd3f27f to 51ac2f5 Compare March 17, 2023 17:20
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

One minor improvement suggested

Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added needs-qa Any New Features that needs a full manual QA prior to being added to a release. team-mobile-client labels Mar 20, 2023
@sethkfman sethkfman added the release-6.3.0 Issue or pull request that will be included in release 6.3.0 label Mar 20, 2023
@VGau VGau force-pushed the feat/consensys-zkevm-support branch 3 times, most recently from ab5376b to 445b319 Compare March 22, 2023 22:36
@VGau VGau force-pushed the feat/consensys-zkevm-support branch from 445b319 to a558b5e Compare March 22, 2023 23:19
Copy link
Copy Markdown
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This PR is 🌮 🌮 🌮

@cortisiko cortisiko added QA Passed QA testing has been completed and passed and removed needs-qa Any New Features that needs a full manual QA prior to being added to a release. labels Mar 23, 2023
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit cafdc63 into MetaMask:main Mar 23, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Mar 23, 2023
@cortisiko cortisiko removed their assignment Mar 31, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-ux Mobile UX team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

QA Passed QA testing has been completed and passed release-6.3.0 Issue or pull request that will be included in release 6.3.0 team-mobile-ux Mobile UX team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants