Skip to content

Extract test accounts to env vars#5952

Merged
NicolasMassart merged 4 commits intomainfrom
e2e/create-env-variable-for-test-wallets
Mar 15, 2023
Merged

Extract test accounts to env vars#5952
NicolasMassart merged 4 commits intomainfrom
e2e/create-env-variable-for-test-wallets

Conversation

@NicolasMassart
Copy link
Copy Markdown
Contributor

@NicolasMassart NicolasMassart commented Mar 10, 2023 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

Extract test accounts SRP and matching addresses to ENV vars that will be provided as secrets in CI.

1. What is the reason for the change?

  • test accounts are automatically drained from any test ETH as SRP is public...
    2. What is the improvement/solution?
  • move infos to env vars
  • setup MM_TEST_ACCOUNT_SRP and MM_TEST_ACCOUNT_ADDRESS secret vars in Bitrise (not env vars).
  • test all tests are passing with the new test account

NOTE: It requires to move tokens and collectibles to this new account

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses MetaMask/mobile-planning#672

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

cortisiko and others added 2 commits February 27, 2023 16:51
@cortisiko
make detox import SRP from accounts.js file.
c82d57c
@NicolasMassart
extract account infos to env vars
a043221 
first pass, some tests are not working because of account change.
@github-actions
Copy link
Copy Markdown
Contributor

github-actions bot commented Mar 10, 2023

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sethkfman
Copy link
Copy Markdown
Contributor

sethkfman commented Mar 14, 2023

@NicolasMassart I would stub these env values out in the js.env file so people know to add them locally for e2e tests. I would also add a section in the e2e ReadMe.

@NicolasMassart NicolasMassart marked this pull request as ready for review March 15, 2023 15:11
@NicolasMassart NicolasMassart requested a review from a team as a code owner March 15, 2023 15:11
sethkfman
sethkfman approved these changes Mar 15, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@sethkfman sethkfman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@sethkfman sethkfman added the No QA Needed Apply this label when your PR does not need any QA effort. label Mar 15, 2023
@NicolasMassart NicolasMassart merged commit 1484a0e into main Mar 15, 2023
@NicolasMassart NicolasMassart deleted the e2e/create-env-variable-for-test-wallets branch March 15, 2023 15:24
@github-actions github-actions bot locked and limited conversation to collaborators Mar 15, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

1 more reviewer

@sethkfman sethkfman sethkfman approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

No QA Needed Apply this label when your PR does not need any QA effort.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@NicolasMassart @sethkfman @cortisiko