Skip to content

E2e appium/5783 tou onboarding new app installs#5951

Merged
chrisleewilcox merged 3 commits intoimplement/466-modal-user-termsfrom
e2e-appium/5783-tou-onboarding-new-app-installs
Mar 13, 2023
Merged

E2e appium/5783 tou onboarding new app installs#5951
chrisleewilcox merged 3 commits intoimplement/466-modal-user-termsfrom
e2e-appium/5783-tou-onboarding-new-app-installs

Conversation

@SamuelSalas
Copy link
Copy Markdown
Contributor

@SamuelSalas SamuelSalas commented Mar 10, 2023

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description
Add test automation scripts for the term of use feature. Both detox and WebdriverIO.

Screenshots/Recordings

/wdio/features/Accounts/CreatingWalletAccount.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/afb95d7fde84972664255a7da6e3b29665f83d16?auth_token=6792268115b96f2f6109fa6097b58480ab9cd98e4cba26f201c1880401fe547c

/wdio/features/Accounts/ImportingAccount.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/5b9f0072f627d22735ed4e11db0865066aa000e8?auth_token=2a988c2bbaf1799e962f3ae8ce71188129423ea21136ce2cc687e453e2c6dcf2

/wdio/features/Onboarding/CreateNewWallet.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/dc9db285b3f32c85309c436c99f03d368dd314ed?auth_token=389f51735aee1d3c5cb459993d17055ba0c32a2e667d2bb41f6b136f07d5dc91

/wdio/features/Onboarding/ImportWallet.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/dbb66da3d1059468d4efc37c76678888a8e9fc50?auth_token=ed700dec84fff5af9dce65c8158b4d3b6fbb76f35c131f42b0f241aa3ee23f74

/wdio/features/Onboarding/ImportWalletRegression.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/44672b8033fc666a8817ac9c35b8e374452c9933?auth_token=4a74d6a50b26641b93249d4d5180c5577994e43a6c53c2e6e92c122147de2372

/wdio/features/Onboarding/OnboardingCarousel.feature - failed
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/ac17ac9c48def9e7c6306683f1108401ad1f5562?auth_token=ee41bb0487e942ebbce52fbda89bf0347d0729efdbd611367822414729053345

/wdio/features/Onboarding/TermsOfUse.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/6e7f79df0c149f4d96866796c314858ef9998dc6?auth_token=b4504bdc4bfa659926edddf85d96b3931c4d4af3129ff2a243d2d7cc25f1bb84

/wdio/features/AddressFlow.feature - failed
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/d6a542c12f02015b0957c78dcfd40492f4d6a94f?auth_token=0e426ef86943e3aa0ed0ceffc2c687e214cc4cf254dd7b48dff8692066447393

/wdio/features/AppLaunchTime.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/4975676409d6f3e99eea1906ae55886ba275b21c?auth_token=2bce1462053c74daf1c730bce01d733b398398221f104457b24ab5a8b08fbebe

/wdio/features/ChangePassword.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/088e66fac2e2a6b959b12b5529650d012aa0d9c0?auth_token=ce8c75e1d055e2ed4501cc943b30f37bc959645361b13cdef862b119a6a5a5fb

/wdio/features/ExploringWizard.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/a7d91900c99120a642007364c0d26f2774d88513?auth_token=40630e45494f01ffc7f98ebdc2d11b6b9bde1f307d12aaf3d4279bc01ae5ea7f

/wdio/features/ImportCustomToken.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/e7e9dc422443cbb626305e8138ae4d125ca66e5c?auth_token=f70b702a82f8dc55d0ec70203b961944ee208ae030a53510df3b10a894897455

/wdio/features/LockResetWallet.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/52be0ab5f60d0e5eb5ca22da9fd1d190ee063483?auth_token=f82c14948ffffa8b736f0a57b8bd0b5dd5d6476757bc71c9783da07c75210c57

/wdio/features/NetworkFlow.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/6217df7d610f48c18fc28fefde21f8bbd2fccbc8?auth_token=203fa29e48c3c02e35d8b3abd38d23f5e9a5f0a8af115b5d65329db056be4273

/wdio/features/RequestTokenFlow.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/108a4ce46dd50c7ca30ccc60d3b6b9eb7d00c85e?auth_token=5fdb06b9f79b8440bba34f54aca8e239919e7852b10841595e91bdbdbe71a5ae

/wdio/features/SecurityPrivacyRememberMe.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/ae5f70fc4624e09c830aa0813e15bd30f204b165?auth_token=d58b122d4133cd5a130b84cb2fbaa909fdc557c77b9294fae05e1c945590280b

/wdio/features/SendToken.feature
https://app-automate.browserstack.com/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/87cd49101b0ec206101883b3a91875501790d262?auth_token=c06ee53b5c17d21ea42c1e541e187d17833412845c07fb987e69bd75e00289a6

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@SamuelSalas SamuelSalas self-assigned this Mar 10, 2023
@SamuelSalas SamuelSalas requested a review from a team as a code owner March 10, 2023 16:10
@SamuelSalas SamuelSalas linked an issue Mar 10, 2023 that may be closed by this pull request
@github-actions
Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@SamuelSalas SamuelSalas changed the base branch from main to implement/466-modal-user-terms March 10, 2023 17:00
Copy link
Copy Markdown
Member

@cortisiko cortisiko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!! 🌮 🌮

Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove this file from your commits.
image

Copy link
Copy Markdown
Contributor

@chrisleewilcox chrisleewilcox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@chrisleewilcox chrisleewilcox merged commit 0cfb06b into implement/466-modal-user-terms Mar 13, 2023
@chrisleewilcox chrisleewilcox deleted the e2e-appium/5783-tou-onboarding-new-app-installs branch March 13, 2023 19:22
@github-actions github-actions bot locked and limited conversation to collaborators Mar 13, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-platform Mobile Platform team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Automation: Add ToU to Onboarding e2e for new mobile app installs

4 participants