[FEATURE] SDK Session Persistence#5948
Merged
christopherferreira9 merged 66 commits intomainfrom Mar 22, 2023
Merged
Conversation
Loading
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Refactor of the SDKConnect class with added MM SDK "session persistence" feature.
SDK Session persistence allows a dApp to automatically reconnect a user to his MetaMask wallet without having to re-approve the connection. This is especially useful to improve the user experience when a user navigate.
New UI to manage SDK sessions moved from "Experimental" to "Advanced" settings of the app.
Added OTP management to secure dApp connection from QR-Code origin.
Current PR includes a copy of the MM SDK
communication-layerprotocol as the npm package hasn't been published yet.Screenshots/Recordings
How to test
@christopherferreira9 has build the tools to develop "Session Persistence" on all platforms supported by MM SDK (JS desktop/mobile, iOS, Unity desktop/mobile) with versions of the SDK supporting session persistence and older versions not yet supporting it (to check retro-compatibility)