Skip to content

[ENHANCEMENT] E2E Permission system tests#5910

Merged
cortisiko merged 28 commits intomainfrom
e2e/enhace-browser-coverage
Mar 22, 2023
Merged

[ENHANCEMENT] E2E Permission system tests#5910
cortisiko merged 28 commits intomainfrom
e2e/enhace-browser-coverage

Conversation

@cortisiko
Copy link
Copy Markdown
Member

@cortisiko cortisiko commented Mar 7, 2023 •
edited
Loading

Development & PR Process

  1. Follow MetaMask Mobile Coding Standards
  2. Add release-xx label to identify the PR slated for a upcoming release (will be used in release discussion)
  3. Add needs-dev-review label when work is completed
  4. Add needs-qa label when dev review is completed
  5. Add QA Passed label when QA has signed off

Description

This PR adds e2e test coverage for the permission system.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses #???

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@cortisiko cortisiko changed the title E2E Permission system tests [ENHANCEMENT] E2E Permission system tests Mar 8, 2023
@cortisiko cortisiko marked this pull request as ready for review March 8, 2023 02:20
@cortisiko cortisiko requested a review from a team as a code owner March 8, 2023 02:20
@cortisiko
Copy link
Copy Markdown
Member Author

cortisiko commented Mar 8, 2023

Browserstack runs for the tests: https://app-automate.browserstack.com/dashboard/v2/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/2bdb86881041963750f251b97e450e384c6a00cd

and this: https://app-automate.browserstack.com/dashboard/v2/builds/8921ccc14ac9135ca38531b8fc30448c28a5e573/sessions/4425a4290f1ec7c39490765de1f7af18fed0a898

@cortisiko
Copy link
Copy Markdown
Member Author

cortisiko commented Mar 8, 2023

Detox is pending. Will leave a message with the build run later.

Andepande
Andepande reviewed Mar 8, 2023
View reviewed changes
Andepande
Andepande approved these changes Mar 8, 2023
View reviewed changes
Copy link
Copy Markdown
Contributor

@Andepande Andepande left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you able to provide screenshots of the test run and links to Browserstack runs?

@cortisiko
Copy link
Copy Markdown
Member Author

cortisiko commented Mar 14, 2023

Are you able to provide screenshots of the test run and links to Browserstack runs?

For sure I got you:
#5910 (comment)

@cortisiko cortisiko merged commit a803bec into main Mar 22, 2023
@cortisiko cortisiko deleted the e2e/enhace-browser-coverage branch March 22, 2023 03:42
@github-actions github-actions bot locked and limited conversation to collaborators Mar 22, 2023
@gauthierpetetin gauthierpetetin added the team-mobile-platform Mobile Platform team label Feb 2, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

2 more reviewers

@SamuelSalas SamuelSalas SamuelSalas approved these changes

@Andepande Andepande Andepande approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

team-mobile-platform Mobile Platform team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cortisiko @SamuelSalas @Andepande @gauthierpetetin