Skip to content

[CONTENT] Add content for "Add friction to revealing SRP"#5535

Merged
gantunesr merged 1 commit intomainfrom
feat/srp-reveal/content
Jan 18, 2023
Merged

[CONTENT] Add content for "Add friction to revealing SRP"#5535
gantunesr merged 1 commit intomainfrom
feat/srp-reveal/content

Conversation

@gantunesr
Copy link
Copy Markdown
Member

@gantunesr gantunesr commented Jan 17, 2023

Description

Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions,

This PR adds the english content for the "Add friction to revealing SRP" Epic. Use the figma file as a reference.

Screenshots/Recordings

If applicable, add screenshots and/or recordings to visualize the before and after of your change

Issue

Progresses https://github.com/MetaMask/mobile-planning/issues/583

Checklist

  • There is a related GitHub issue
  • Tests are included if applicable
  • Any added code is fully documented

@gantunesr gantunesr added No QA Needed Apply this label when your PR does not need any QA effort. needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) labels Jan 17, 2023
@coreyjanssen
Copy link
Copy Markdown
Contributor

The Ready for Dev page in Figma is good to go from a content perspective!

@gantunesr gantunesr marked this pull request as ready for review January 18, 2023 20:03
@gantunesr gantunesr requested a review from a team as a code owner January 18, 2023 20:03
Copy link
Copy Markdown
Contributor

@Cal-L Cal-L left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gantunesr gantunesr removed the needs-dev-review PR needs reviews from other engineers (in order to receive required approvals) label Jan 18, 2023
@gantunesr gantunesr merged commit c07a230 into main Jan 18, 2023
@gantunesr gantunesr deleted the feat/srp-reveal/content branch January 18, 2023 20:06
@gantunesr gantunesr added the release-5.14.0 Issue or pull request that will be included in release 5.14.0 label Jan 18, 2023
@github-actions github-actions bot locked and limited conversation to collaborators Jan 18, 2023
@gantunesr gantunesr added the team-accounts-framework Accounts team label Jan 24, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-5.14.0 Issue or pull request that will be included in release 5.14.0 team-accounts-framework Accounts team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants