Fixed failing e2e tests and made minor adjustments#5498
Closed
Andepande wants to merge 5 commits into
Closed
Conversation
SamuelSalas
reviewed
Jan 13, 2023
cortisiko
requested changes
Jan 13, 2023
cortisiko
left a comment
Member
There was a problem hiding this comment.
left a couple of thangsss, take a look when you get a chance @Andepande
chrisleewilcox
requested changes
Jan 13, 2023
Fatxx
suggested changes
Jan 16, 2023
cortisiko
requested changes
Jan 16, 2023
Fatxx
approved these changes
Jan 17, 2023
cortisiko
reviewed
Jan 17, 2023
| When I tap on the navbar network title button | ||
| And I tap on <NETWORK> on Networks list to switch | ||
| And I tap on Got it in the network education modal | ||
| And I tap on Goerli Test Network on Networks list to switch |
Member
There was a problem hiding this comment.
can we revert the changes made in this file? This feature file was created to be the stepping stone for the Send tokens feature file.
cortisiko
reviewed
Jan 17, 2023
| And "CUSTOM NETWORKS" tab is displayed on networks screen | ||
| When I tap on the "CUSTOM NETWORKS" tab | ||
| Then Add button is disabled | ||
| # Then Add button is disabled |
Member
There was a problem hiding this comment.
probably remove this comment?
cortisiko
reviewed
Jan 17, 2023
| And "CUSTOM NETWORKS" tab is displayed on networks screen | ||
| When I tap on the "CUSTOM NETWORKS" tab | ||
| Then Add button is disabled | ||
| # Then Add button is disabled |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Development & PR Process
release-xxlabel to identify the PR slated for a upcoming release (will be used in release discussion)needs-dev-reviewlabel when work is completedneeds-qalabel when dev review is completedQA Passedlabel when QA has signed offDescription
A number of e2e/appium tests were failing, this PR fixes those failures with some minor adjustments to the running of wdio tests
Checklist