Skip to content

[WIP] SES lockdown() - LavaMoat Compatibility#3794

Closed
bentobox19 wants to merge 3 commits into
mainfrom
feature/ses-lockdown
Closed

[WIP] SES lockdown() - LavaMoat Compatibility#3794
bentobox19 wants to merge 3 commits into
mainfrom
feature/ses-lockdown

Conversation

@bentobox19

@bentobox19 bentobox19 commented Feb 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

Compatibility Documentation: LavaMoat/docs#1

  • Add ses dependency
    • Tell babel to ignore its transformation
    • Tell metro to accept a .cjs file as dependency entry point
  • Add SES lockdown() call
  • Modifications required for the application to work
    • Disable default integration in Sentry
    • Add patches
      • React Native to disable Promise polyfill
      • Metro React Native Babel Preset to disable two plugins
      • ethjs dependencies leveraging babel runtime
      • web3 dependency assigning a frozen intrinsic.

Extensive QA required ❗

@bentobox19 bentobox19 self-assigned this Feb 22, 2022
@github-actions

github-actions Bot commented Feb 22, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@bentobox19

bentobox19 commented Feb 22, 2022

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@bentobox19 bentobox19 mentioned this pull request Feb 25, 2022
Closed
11 tasks
@bentobox19 bentobox19 force-pushed the feature/ses-lockdown branch from 3dad8b6 to 29bc828 Compare March 19, 2022 20:07
@bentobox19

bentobox19 commented Mar 19, 2022 •
edited
Loading

Copy link
Copy Markdown
Contributor Author

Force pushed a shorter and cleaner version of the changes needed to run lockdown().

@bentobox19 bentobox19 force-pushed the feature/ses-lockdown branch 2 times, most recently from eb673a0 to af66e5c Compare June 8, 2022 02:27
@bentobox19

bentobox19 commented Jun 8, 2022

Copy link
Copy Markdown
Contributor Author

New force push

@bentobox19 bentobox19 force-pushed the feature/ses-lockdown branch from af66e5c to 125b72c Compare June 27, 2022 06:23
@bentobox19

bentobox19 commented Aug 1, 2022

Copy link
Copy Markdown
Contributor Author

I have read the CLA Document and I hereby sign the CLA

@bentobox19 bentobox19 force-pushed the feature/ses-lockdown branch from 5935751 to 1a6b291 Compare August 2, 2022 02:52
@gantunesr

gantunesr commented Dec 19, 2022

Copy link
Copy Markdown
Member

Closed per sync with @bentobox19

@gantunesr gantunesr closed this Dec 19, 2022
@github-actions github-actions Bot locked and limited conversation to collaborators Dec 19, 2022
@legobeat

legobeat commented May 3, 2023

Copy link
Copy Markdown
Contributor

@bentobox19 @gantunesr Would you be able to share some context on this and the decision to close it?

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

No reviews

Assignees

@bentobox19 bentobox19

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@bentobox19 @gantunesr @legobeat