fix: Update TPC version for fiat payments in MMPay#31627
Conversation
PR template — items to address before "Ready for review"Warnings — informational, address before merging:
See docs/readme/ready-for-review.md for the full Definition of Ready for Review. |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
⚡ Performance Test Results
✅ All tests passed · 2 tests · 1 device 📱 Devices tested (1)Android: Google Pixel 8 Pro (v14.0) ✅ Passed Tests (2)
Branch: |
Description
Bumps
@metamask/transaction-pay-controllerfrom23.5.0to23.6.0inpackage.jsonand refreshesyarn.lockto pull in the corresponding transitive dependency updates. There are no application source changes in this PR.Why: fiat payments in MMPay were broken on the previous TPC version. Version
23.6.0lands the upstream fixes and behavior changes required to restore that flow.What changes in TPC
23.6.0:useFiatMUSDQuoteToInjectForMoneyAccountfeature flag. When enabled and a provider supports mUSD on Monad, fiat is used to purchase mUSD directly into the Money Account, skipping the ETH→mUSD bridge. Falls back to the existing flow otherwise. Also movesfiatPayment.caipAssetIdassignment into the fiat quote functions so the asset ID always matches the quote that succeeded. (core#9080)confirmations_pay_fiat.orderPollIntervalMsandconfirmations_pay_fiat.orderPollTimeoutMsfeature flags. (core#9090)fiatPayment.rampsQuotewhen a fiat quote fetch fails, preventing the "No quotes" alert from being silently suppressed after a prior successful fetch. (core#9073)Full upstream changelog:
@metamask/transaction-pay-controller@23.6.0.Changelog
CHANGELOG entry: Fixed fiat payments in MMPay by updating
@metamask/transaction-pay-controllerto23.6.0.Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
N/A — dependency-only bump, no UI changes.
After
N/A — dependency-only bump, no UI changes.
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Touches money-movement and pay/ramps controllers via a transitive dependency upgrade without local code review of upstream behavior; regression risk is mainly in fiat/MMPay flows.
Overview
Bumps
@metamask/transaction-pay-controllerfrom 23.5.0 to 23.6.0 inpackage.jsonand refreshesyarn.lock. There are no application source changes in this PR.The new TPC release pulls updated transitive packages, including
@metamask/assets-controller9.x,@metamask/bridge-controller75.1.1,@metamask/ramps-controller14.2.0, and a newertransaction-controllerrevision inside TPC’s dependency tree—aligned with the PR goal of fixing fiat payments in MMPay.Reviewed by Cursor Bugbot for commit b8eb5d2. Bugbot is set up for automated code reviews on this repo. Configure here.