Skip to content

chore(runway): cherry-pick fix(perps): prevent Android crash in tutorial carousel Rive animations cp-7.81.0#31557

Merged
sleepytanya merged 1 commit into
release/7.81.0from
runway-cherry-pick-7.81.0-1781180500
Jun 11, 2026
Merged

chore(runway): cherry-pick fix(perps): prevent Android crash in tutorial carousel Rive animations cp-7.81.0#31557
sleepytanya merged 1 commit into
release/7.81.0from
runway-cherry-pick-7.81.0-1781180500

Conversation

@runway-github

@runway-github runway-github Bot commented Jun 11, 2026

Copy link
Copy Markdown
Contributor

Description

The Perps "Learn the basics" tutorial carousel crashes on Android when
navigating through the screens.

Root cause: ScrollableTabView renders all child tabs
simultaneously, which means 4–5 <Rive> components (one per tutorial
screen with an animation) are all mounted with autoplay={true} at the
same time. On Android, the Rive native renderer cannot handle multiple
concurrent GPU-accelerated animation instances and crashes.

Fix: Only mount the <Rive> component for the currently visible tab
(currentTab === index). This ensures a single native Rive renderer
instance exists at any time. When the user swipes or taps Continue, the
previous instance is unmounted and the next one takes its place.

iOS is unaffected because its Metal rendering pipeline handles
concurrent Rive instances more gracefully.

Changelog

CHANGELOG entry: Fixed a crash on Android when navigating through the
Perps tutorial carousel

Related issues

Fixes: #31540

Manual testing steps

Feature: Perps tutorial carousel stability on Android

  Scenario: user completes the full tutorial without crash
    Given the user has not completed the Perps tutorial
    When user taps Perps and goes through "Learn the Basics of Perps"
    Then the app does not crash
    And all tutorial screens display their Rive animations correctly

  Scenario: user re-enters tutorial from Perps home
    Given the user is on the Perps home screen
    When user scrolls down and taps "Learn the Basics of Perps"
    And user taps Continue through all screens
    Then the app does not crash
    And the user reaches the final screen successfully

Screenshots/Recordings

N/A — no visual change; this is a crash fix. The tutorial screens render
identically, only one Rive animation is mounted at a time instead of all
simultaneously.

Before

App crashes on Android when navigating through tutorial carousel
screens.

After

Tutorial carousel completes without crash on Android.

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Low Risk
Single conditional around Rive mounting in the tutorial carousel;
behavior is unchanged except avoiding concurrent animations on Android.

Overview
Fixes an Android crash in the Perps “Learn the basics” tutorial by
ensuring only one native Rive animation is mounted at a time.

ScrollableTabView keeps every tab’s children in the tree, so every
screen with riveArtboardName used to mount <Rive autoplay> together.
The change adds index in the screen map and renders the animation only
when currentTab === index, so swiping or tapping Continue unmounts
the previous instance before the next one loads. No intended UI change
on iOS.

Reviewed by Cursor Bugbot for commit
17b73bc. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[fe7877a](https://github.com/MetaMask/metamask-mobile/commit/fe7877a2f721406e9e2c6e26e67ff23f6fe5943a)

…ial carousel Rive animations cp-7.81.0 (#31547)

## **Description**

The Perps "Learn the basics" tutorial carousel crashes on Android when
navigating through the screens.

**Root cause:** `ScrollableTabView` renders all child tabs
simultaneously, which means 4–5 `<Rive>` components (one per tutorial
screen with an animation) are all mounted with `autoplay={true}` at the
same time. On Android, the Rive native renderer cannot handle multiple
concurrent GPU-accelerated animation instances and crashes.

**Fix:** Only mount the `<Rive>` component for the currently visible tab
(`currentTab === index`). This ensures a single native Rive renderer
instance exists at any time. When the user swipes or taps Continue, the
previous instance is unmounted and the next one takes its place.

iOS is unaffected because its Metal rendering pipeline handles
concurrent Rive instances more gracefully.

## **Changelog**

CHANGELOG entry: Fixed a crash on Android when navigating through the
Perps tutorial carousel

## **Related issues**

Fixes: #31540

## **Manual testing steps**

```gherkin
Feature: Perps tutorial carousel stability on Android

  Scenario: user completes the full tutorial without crash
    Given the user has not completed the Perps tutorial
    When user taps Perps and goes through "Learn the Basics of Perps"
    Then the app does not crash
    And all tutorial screens display their Rive animations correctly

  Scenario: user re-enters tutorial from Perps home
    Given the user is on the Perps home screen
    When user scrolls down and taps "Learn the Basics of Perps"
    And user taps Continue through all screens
    Then the app does not crash
    And the user reaches the final screen successfully
```

## **Screenshots/Recordings**

N/A — no visual change; this is a crash fix. The tutorial screens render
identically, only one Rive animation is mounted at a time instead of all
simultaneously.

### **Before**

App crashes on Android when navigating through tutorial carousel
screens.

### **After**

Tutorial carousel completes without crash on Android.

## **Pre-merge author checklist**

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [x] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [x] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [x] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> Single conditional around Rive mounting in the tutorial carousel;
behavior is unchanged except avoiding concurrent animations on Android.
> 
> **Overview**
> Fixes an **Android crash** in the Perps “Learn the basics” tutorial by
ensuring only one native **Rive** animation is mounted at a time.
> 
> `ScrollableTabView` keeps every tab’s children in the tree, so every
screen with `riveArtboardName` used to mount `<Rive autoplay>` together.
The change adds `index` in the screen map and renders the animation only
when **`currentTab === index`**, so swiping or tapping Continue unmounts
the previous instance before the next one loads. No intended UI change
on iOS.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
17b73bc. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner June 11, 2026 12:21
@github-actions

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Jun 11, 2026
@github-actions

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable)

All E2E tests pre-selected.

View GitHub Actions results

@sleepytanya sleepytanya merged commit b075cf6 into release/7.81.0 Jun 11, 2026
207 checks passed
@sleepytanya sleepytanya deleted the runway-cherry-pick-7.81.0-1781180500 branch June 11, 2026 13:13
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 11, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-XS team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants