Description

Removes the saveDataRecording field from AnalyticsTrackingEvent/ITrackingEvent and the setSaveDataRecording method from AnalyticsEventBuilderInterface. This field was introduced to mirror the legacy MetricsEventBuilder API but was never actually used at runtime — the data-recording chain has been removed in #31256.

⚠️ Merge order: This PR targets analytics/pr8-deletion and must be merged after #31256. Once #31256 lands on main, this PR will be retargeted to main.

Changes:

• AnalyticsEventBuilder.ts — removes saveDataRecording from AnalyticsTrackingEvent interface and setSaveDataRecording from the builder
• analytics.types.ts — removes saveDataRecording from ITrackingEvent; updates isTrackingEvent guard to use name-based check
• Controller inits (token-detection, smart-transactions, defi-positions, account-tree, analytics.ts) — adds as unknown cast where the messenger call expects the @metamask/analytics-controller package type (which still carries saveDataRecording until the package drops it)
• Tokens/util/removeEvmToken.ts + goToAddEvmToken.ts — removes the optional saveDataRecording?: boolean prop-type
• All test mocks — removes saveDataRecording: <value> and setSaveDataRecording: jest.fn() across 20+ test files

Note: actionButtonTracking.test.ts has one pre-existing failing test on main that is unrelated to this change (tracked by #31019).

Changelog

CHANGELOG entry: null

Related issues

Refs: #26686

Manual testing steps

N/A — analytics-only refactor, no behaviour change.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
• I've tested with a power user scenario
• I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor