Skip to content

chore(analytics): migrate MetricsEventBuilder→AnalyticsEventBuilder in TransactionField test (engagement)#31254

Merged
NicolasMassart merged 1 commit into
mainfrom
analytics/pr6-engagement
Jun 9, 2026
Merged

chore(analytics): migrate MetricsEventBuilder→AnalyticsEventBuilder in TransactionField test (engagement)#31254
NicolasMassart merged 1 commit into
mainfrom
analytics/pr6-engagement

Conversation

@NicolasMassart

@NicolasMassart NicolasMassart commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

Description

Migrates the TransactionField notification test from MetricsEventBuilder to AnalyticsEventBuilder.

Part of the analytics migration cleanup series.

Changelog

CHANGELOG entry: null

Related issues

Refs: #26686

Manual testing steps

N/A — test-only change.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Low Risk
Test-only import and assertion updates with no runtime or production impact.

Overview
Updates TransactionField.test.tsx so notification copy analytics expectations use AnalyticsEventBuilder from util/analytics instead of MetricsEventBuilder from core/Analytics, including the import, the useAnalytics mock’s createEventBuilder, and the asserted event built in the copy-button test.

No production code changes; behavior under test is unchanged aside from aligning with the analytics migration (#26686).

Reviewed by Cursor Bugbot for commit 5981942. Bugbot is set up for automated code reviews on this repo. Configure here.

…in TransactionField test (engagement)

Updates TransactionField.test.tsx mock to use AnalyticsEventBuilder instead of MetricsEventBuilder.

Co-authored-by: Cursor <cursoragent@cursor.com>
@NicolasMassart NicolasMassart self-assigned this Jun 9, 2026
@github-actions

github-actions Bot commented Jun 9, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-mobile-platform Mobile Platform team label Jun 9, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added INVALID-PR-TEMPLATE PR's body doesn't match template and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 9, 2026
@NicolasMassart NicolasMassart marked this pull request as ready for review June 9, 2026 08:57
@NicolasMassart NicolasMassart requested a review from a team as a code owner June 9, 2026 08:57
@github-actions github-actions Bot added the risk:low AI analysis: low risk label Jun 9, 2026
@NicolasMassart NicolasMassart added this pull request to the merge queue Jun 9, 2026
Merged via the queue into main with commit 1f68123 Jun 9, 2026
103 checks passed
@NicolasMassart NicolasMassart deleted the analytics/pr6-engagement branch June 9, 2026 13:20
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 9, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.82.0 Issue or pull request that will be included in release 7.82.0 label Jun 9, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.82.0 Issue or pull request that will be included in release 7.82.0 risk:low AI analysis: low risk size-XS team-mobile-platform Mobile Platform team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants