chore(analytics): remove stale MetricsEventBuilder mock from AccountsMenu test (core-ux)#31253
Merged
Conversation
…Menu test (core-ux) AccountsMenu.tsx was already using useAnalytics directly. Removes the now-redundant MetricsEventBuilder mock from AccountsMenu.test.tsx. Co-authored-by: Cursor <cursoragent@cursor.com>
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
10 tasks
PatrykLucka
approved these changes
Jun 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Removes the stale
MetricsEventBuildermock reference from theAccountsMenutest file. The component was already migrated toAnalyticsEventBuilder; this cleans up the leftover mock.Part of the analytics migration cleanup series.
Changelog
CHANGELOG entry: null
Related issues
Refs: #26686
Manual testing steps
N/A — test-only change.
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Performance checks (if applicable)
Pre-merge reviewer checklist
Made with Cursor
Note
Low Risk
Test-only cleanup with no production or runtime behavior changes.
Overview
Removes the unused
jest.mockforMetricsEventBuilderfromAccountsMenu.test.tsxas part of analytics migration cleanup.Analytics in these tests is already covered by the
useAnalyticsmock (trackEvent,createEventBuilder); the old core builder mock was redundant and no longer referenced.Reviewed by Cursor Bugbot for commit c1de9c1. Bugbot is set up for automated code reviews on this repo. Configure here.