chore(analytics): migrate useMetrics→useAnalytics and MetricsEventBuilder→AnalyticsEventBuilder (assets files) by NicolasMassart · Pull Request #31251 · MetaMask/metamask-mobile

NicolasMassart · 2026-06-09T07:56:03Z

Description

Migrates assets-related test files from the legacy analytics system (useMetrics, MetricsEventBuilder, addTraitsToUser) to the new system (useAnalytics, AnalyticsEventBuilder, identify).

Part of the analytics migration cleanup series. All changes are in files owned by the assets team.

Files migrated: DeFiPositionsListItem.test.tsx, TokenList.test.tsx, TokenListItem.test.tsx, NftDetails.test.ts.

Note: TokenListItem.test.tsx has a pre-existing test failure on main unrelated to this change (tracked by #31019).

Changelog

CHANGELOG entry: null

Related issues

Refs: #26686

Manual testing steps

N/A — analytics-only refactor, no behaviour change.

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
I've completed the PR template to the best of my ability
I've included tests if applicable
I've documented my code using JSDoc format if applicable
I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

I've tested on Android
I've tested with a power user scenario
I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor

Note

Low Risk
Changes are limited to test mocks and import paths; runtime wallet/assets behavior is unchanged.

Overview
Updates assets-team unit tests so mocks and assertions match the new analytics API—no production code changes.

DeFi / token list tests swap MetricsEventBuilder for AnalyticsEventBuilder (imports and jest.requireActual paths under util/analytics). DeFi navigation analytics expectations now build events with AnalyticsEventBuilder.createEventBuilder.

TokenList.test.tsx extends the useAnalytics mock with identify and a default isDataRecorded implementation so it mirrors the current hook surface.

TokenListItem.test.tsx loads MetaMetricsEvents from core/Analytics instead of the legacy useMetrics path for mUSD CTA event assertions.

NftDetails.test.ts aligns the useAnalytics mock with the new API (identify; drops unused legacy mock fields like addTraitsToUser / isDataRecorded where no longer needed).

^{Reviewed by Cursor Bugbot for commit e33ebdf. Bugbot is set up for automated code reviews on this repo. Configure here.}

…er->AnalyticsEventBuilder, addTraitsToUser->identify (assets files) Migrates 4 asset-owned test files: TokenListItem (useMetrics), DeFiPositionsListItem (MetricsEventBuilder), TokenList and NftDetails (identify rename). Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions · 2026-06-09T07:56:15Z

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

cursor

Cursor Bugbot has reviewed your changes and found 1 potential issue.

^{❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.}

^{Reviewed by Cursor Bugbot for commit c428e99. Configure here.}

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: c428e99cf7

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

…enList mock Co-authored-by: Cursor <cursoragent@cursor.com>

…okenListItem test Co-authored-by: Cursor <cursoragent@cursor.com>

NicolasMassart self-assigned this Jun 9, 2026

mm-token-exchange-service Bot added the team-mobile-platform Mobile Platform team label Jun 9, 2026

github-actions Bot added the size-S label Jun 9, 2026

mm-token-exchange-service Bot added INVALID-PR-TEMPLATE PR's body doesn't match template and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 9, 2026

NicolasMassart mentioned this pull request Jun 9, 2026

chore(analytics): delete legacy analytics symbols (useMetrics, MetaMetrics, MetricsEventBuilder) and remove saveDataRecording chain #31256

Open

10 tasks

NicolasMassart marked this pull request as ready for review June 9, 2026 08:57

NicolasMassart requested a review from a team as a code owner June 9, 2026 08:57

cursor Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread app/components/UI/Tokens/TokenList/TokenListItem/TokenListItem.test.tsx Outdated

github-actions Bot added the risk:medium AI analysis: medium risk label Jun 9, 2026

chatgpt-codex-connector Bot reviewed Jun 9, 2026

View reviewed changes

Comment thread app/components/UI/Tokens/TokenList/TokenListItem/TokenListItem.test.tsx Outdated

fix(analytics): add missing addTraitsToUser and isDataRecorded to Tok…

e33ebdf

…enList mock Co-authored-by: Cursor <cursoragent@cursor.com>

github-actions Bot added risk:low AI analysis: low risk and removed risk:medium AI analysis: medium risk labels Jun 9, 2026

NicolasMassart marked this pull request as draft June 9, 2026 09:43

fix(analytics): correct requireActual path for MetaMetricsEvents in T…

10f2ae3

…okenListItem test Co-authored-by: Cursor <cursoragent@cursor.com>

NicolasMassart marked this pull request as ready for review June 9, 2026 10:39

Prithpal-Sooriya approved these changes Jun 9, 2026

View reviewed changes

NicolasMassart added this pull request to the merge queue Jun 9, 2026

Merged via the queue into main with commit bb43735 Jun 9, 2026
63 checks passed

NicolasMassart deleted the analytics/pr3-assets branch June 9, 2026 13:20

github-actions Bot locked and limited conversation to collaborators Jun 9, 2026

metamaskbotv2 Bot added the release-7.82.0 Issue or pull request that will be included in release 7.82.0 label Jun 9, 2026

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Uh oh!

chore(analytics): migrate useMetrics→useAnalytics and MetricsEventBuilder→AnalyticsEventBuilder (assets files)#31251

chore(analytics): migrate useMetrics→useAnalytics and MetricsEventBuilder→AnalyticsEventBuilder (assets files)#31251
NicolasMassart merged 3 commits into
mainfrom
analytics/pr3-assets

NicolasMassart commented Jun 9, 2026 •

edited by cursor Bot

Loading

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

cursor Bot left a comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

Uh oh!

Conversation

NicolasMassart commented Jun 9, 2026 • edited by cursor Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Description

Changelog

Related issues

Manual testing steps

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

Pre-merge reviewer checklist

Uh oh!

github-actions Bot commented Jun 9, 2026

Uh oh!

cursor Bot left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants

NicolasMassart commented Jun 9, 2026 •

edited by cursor Bot

Loading