fix: Smoke e2e tests flakiness#31177
Merged
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
sleepytanya
previously approved these changes
Jun 6, 2026
jvbriones
previously approved these changes
Jun 6, 2026
7c3b1a5 to
6cf97a8
Compare
04e58a0 to
e304362
Compare
hjetpoluru
previously approved these changes
Jun 8, 2026
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
hjetpoluru
approved these changes
Jun 8, 2026
amitabh94
approved these changes
Jun 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
gasless-swap.spec.tsbridge-action-smoke.spec.tsdismissKeypad()to after the network fee label assertion (instead of before)TestSnaps.tscheckStability: truefrom date-time picker, date picker, and time picker OK button tapsonramp-unified-buy.spec.tsRemoteFeatureFlagControllerinitial state via.withRampsUnifiedBuyRemoteFlagsSeededForE2E(), so flags are available on first render without waiting for the mock serverremoteFeatureFlagRampsUnifiedEnabled(minimumVersion: '7.63.0') toremoteFeatureFlagRampsUnifiedMatrixForE2E(true, true)('0.0.0'), keeping consistency with seeded state if the controller refreshes mid-teststake-action-smoke.spec.tsChangelog
CHANGELOG entry:
Related issues
Fixes: test falkiness on stake and bridge tests
Manual testing steps
N/A
Screenshots/Recordings
Before
test.mp4
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Changes are limited to E2E tests and mock helpers; production wallet code is untouched.
Overview
Stabilizes smoke E2E by tightening waits, mocks, and test ordering—no production app behavior changes.
Swap / STX mocks: Sentinel URL matchers now accept versioned
*.api.cx.metamask.iopaths (not onlytransaction.api…). New mocks cover the EIP-7702 gasless relay path (eth_sendRelayTransaction+ relay polling), with a dummy Anvil tx so receipts resolve. Gasless swap specs are re-enabled (removedit.skip).Bridge smoke:
dismissKeypad()runs after waiting for the network fee label (60s), so quote loading isn’t disrupted.Onramp unified buy: Fixtures seed unified-buy remote flags via
.withRampsUnifiedBuyRemoteFlagsSeededForE2E()and mocks useremoteFeatureFlagRampsUnifiedMatrixForE2Eto avoid flag-load races.Detox / timing:
waitForAppReadydefault 60s; stake Earn button wait 60s; TestSnaps picker OK taps dropcheckStabilityon iOS where calendar animation blocks stability checks.Reviewed by Cursor Bugbot for commit 297372c. Bugbot is set up for automated code reviews on this repo. Configure here.