Skip to content

chore: cleanup perps top movers buttons cp-7.81.0#31147

Merged
gambinish merged 1 commit into
mainfrom
fix/perps/top-movers-layout
Jun 5, 2026
Merged

chore: cleanup perps top movers buttons cp-7.81.0#31147
gambinish merged 1 commit into
mainfrom
fix/perps/top-movers-layout

Conversation

@gambinish

@gambinish gambinish commented Jun 5, 2026 •
edited
Loading

Copy link
Copy Markdown
Member

Description

Makes Gainers/Loser buttons larger and more accessible

Changelog

CHANGELOG entry: null

Related issues

Fixes: css bug

Manual testing steps

N/A

Screenshots/Recordings

Screenshot 2026-06-05 at 6 54 09 AM

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Cosmetic Tailwind class changes on a Perps home UI toggle with no logic, data, or auth impact.

Overview
Updates the Gainers / Losers toggle styling in PerpsTopMoversSection so the pills are easier to tap and read.

TogglePill now uses rounded-lg instead of rounded-xl, adds justify-center and py-1 for vertical padding and centered label alignment—matching the PR goal of larger, more accessible buttons.

Reviewed by Cursor Bugbot for commit 52ad854. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 5, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added team-perps Perps team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 5, 2026
@gambinish gambinish marked this pull request as ready for review June 5, 2026 13:54
@gambinish gambinish requested a review from a team as a code owner June 5, 2026 13:54
@gambinish gambinish enabled auto-merge June 5, 2026 13:56
@mm-token-exchange-service mm-token-exchange-service Bot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 5, 2026
@gambinish gambinish removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 5, 2026
@github-actions

github-actions Bot commented Jun 5, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokePerps, SmokeWalletPlatform
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
The change is a minimal UI styling tweak to the TogglePill component in PerpsTopMoversSection: changing 'rounded-xl' to 'rounded-lg' and adding 'justify-center py-1'. This is a pure visual/CSS change with no functional, state, or behavioral modifications.

SmokePerps is selected because the changed component (PerpsTopMoversSection → PerpsHomeView) is directly exercised by Perps smoke tests, and the styling change should be validated to ensure it doesn't break layout or accessibility.

SmokeWalletPlatform is selected per the SmokePerps tag description which states: 'Perps is also a section inside the Trending tab (SmokeWalletPlatform); changes to Perps views affect Trending.'

SmokeConfirmations is NOT selected because the styling change doesn't affect the Add Funds transaction flow - it only modifies the visual appearance of a toggle pill component.

No other tags are relevant as this change is isolated to the Perps UI component with no cross-cutting impact.

Performance Test Selection:
This is a trivial CSS styling change (border radius and padding adjustment on a toggle pill). It does not affect rendering performance, data loading, state management, or any critical user flows in a meaningful way. No performance tests are warranted.

View GitHub Actions results

@gambinish gambinish added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit b400262 Jun 5, 2026
201 of 212 checks passed
@gambinish gambinish deleted the fix/perps/top-movers-layout branch June 5, 2026 15:36
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 5, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.82.0 Issue or pull request that will be included in release 7.82.0 label Jun 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@aganglada aganglada aganglada approved these changes

Assignees

No one assigned

Labels

release-7.82.0 Issue or pull request that will be included in release 7.82.0 size-XS team-perps Perps team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@gambinish @aganglada