Skip to content

fix: disable link unfurling in Slack RC notifications to prevent large preview images #31116

Merged
sleepytanya merged 2 commits into
mainfrom
disable-unfurl-slack-notification
Jun 5, 2026
Merged

fix: disable link unfurling in Slack RC notifications to prevent large preview images #31116
sleepytanya merged 2 commits into
mainfrom
disable-unfurl-slack-notification

Conversation

@sleepytanya

@sleepytanya sleepytanya commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description

Disable link unfurling in Slack RC notifications to prevent large preview images

Changelog

CHANGELOG entry: null

Related issues

TestFlight link preview with large image displayed in the Slack RC build notification.
Fixes: disables unfurl

Manual testing steps

N/A —

Screenshots/Recordings

Before

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Single optional API flags on an internal release-notification script with no app or security impact.

Overview
RC build Slack notifications now pass unfurl_links: false and unfurl_media: false on chat.postMessage, so Slack stops expanding download, GitHub, and pipeline URLs into large link previews in release channels.

Reviewed by Cursor Bugbot for commit 3448f28. Bugbot is set up for automated code reviews on this repo. Configure here.

@sleepytanya sleepytanya requested a review from a team as a code owner June 4, 2026 22:33
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@sleepytanya sleepytanya enabled auto-merge June 4, 2026 22:34
@mm-token-exchange-service mm-token-exchange-service Bot added team-qa QA team INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 4, 2026
@sleepytanya sleepytanya added No QA Needed Apply this label when your PR does not need any QA effort. release-7.81.0 Issue or pull request that will be included in release 7.81.0 labels Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 99%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only changed file is scripts/slack-rc-notification.mjs, a Slack notification script used during the release candidate process. The change adds unfurl_links: false and unfurl_media: false to the Slack API payload to suppress link/media previews in Slack messages. This is a pure infrastructure/notification script change with zero impact on:

  • App source code or functionality
  • E2E test flows or test infrastructure
  • Any controllers, components, or user-facing features
  • Performance characteristics

No E2E tests need to run for this change.

Performance Test Selection:
The change is limited to a Slack notification script and has no impact on app performance, UI rendering, data loading, or any user-facing flows.

View GitHub Actions results

@sleepytanya sleepytanya disabled auto-merge June 4, 2026 23:09
@sleepytanya sleepytanya enabled auto-merge June 4, 2026 23:09
@mm-token-exchange-service mm-token-exchange-service Bot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 4, 2026
@sleepytanya sleepytanya added this pull request to the merge queue Jun 5, 2026
Merged via the queue into main with commit 1bc6039 Jun 5, 2026
207 of 222 checks passed
@sleepytanya sleepytanya deleted the disable-unfurl-slack-notification branch June 5, 2026 02:02
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 5, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.82.0 Issue or pull request that will be included in release 7.82.0 label Jun 5, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.81.0 Issue or pull request that will be included in release 7.81.0 release-7.82.0 Issue or pull request that will be included in release 7.82.0 size-XS team-qa QA team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants