Skip to content

test(e2e): stabilize TestSnaps date/time picker taps#31085

Merged
chrisleewilcox merged 2 commits into
mainfrom
MMQA-1900-stabilize-testsnaps-datetime-picker
Jun 4, 2026
Merged

test(e2e): stabilize TestSnaps date/time picker taps#31085
chrisleewilcox merged 2 commits into
mainfrom
MMQA-1900-stabilize-testsnaps-datetime-picker

Conversation

@chrisleewilcox

@chrisleewilcox chrisleewilcox commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description

Adds checkStability and elemDescription options to the Gestures.waitAndTap calls inside the date, time, and date-time picker helpers in the TestSnaps page object. Stability checks prevent taps from firing on an element while it is still animating, and the descriptions surface clearer messages when a tap fails. No production code is affected.

Changelog

CHANGELOG entry: null

Related issues

Fixes: MMQA-1900

Manual testing steps

Feature: TestSnaps date/time picker E2E helpers

  Scenario: e2e suite drives the date-time picker via TestSnaps page object
    Given the test-snaps dapp is loaded on a device

    When the suite invokes selectDateInDateTimePicker / selectDateInDatePicker / selectTimeInTimePicker
    Then each tap waits for element stability before firing
    And failures report a human-readable element description

Screenshots/Recordings

Before

N/A — test-only change.

After

Coverage is provided by CI. All four snap Android smoke shards (which exercise the affected TestSnaps helpers) passed on this branch:

  • snaps-android-smoke (1) — pass
  • snaps-android-smoke (2) — pass
  • snaps-android-smoke (3) — pass
  • snaps-android-smoke (4) — pass

See checks on this PR for the run: https://github.com/MetaMask/metamask-mobile/pull/31085/checks

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Pass checkStability + elemDescription to Gestures.waitAndTap so the date,
time, and date-time picker interactions wait for element stability and
produce clearer failure messages.

Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 4, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added the team-qa QA team label Jun 4, 2026
@github-actions github-actions Bot added the size-S label Jun 4, 2026
@chrisleewilcox chrisleewilcox marked this pull request as ready for review June 4, 2026 15:03
@chrisleewilcox chrisleewilcox requested a review from a team as a code owner June 4, 2026 15:03

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 0a6a64c. Configure here.

Comment thread tests/page-objects/Browser/TestSnaps.ts
@github-actions github-actions Bot added the risk:high AI analysis: high risk label Jun 4, 2026
@chrisleewilcox chrisleewilcox removed the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSnaps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: medium
  • AI Confidence: 92%
click to see 🤖 AI reasoning details

E2E Test Selection:
Shared test infra changed (tests/page-objects/Browser/TestSnaps.ts). Found 24 affected spec file(s). Running tags: SmokeSnaps

Performance Test Selection:
No performance impact from shared test infra changes

View GitHub Actions results

@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.99%. Comparing base (000d79f) to head (34de298).
⚠️ Report is 85 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #31085      +/-   ##
==========================================
+ Coverage   82.86%   82.99%   +0.13%     
==========================================
  Files        5582     5605      +23     
  Lines      144198   144354     +156     
  Branches    33521    33535      +14     
==========================================
+ Hits       119483   119801     +318     
+ Misses      16682    16482     -200     
- Partials     8033     8071      +38     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@chrisleewilcox chrisleewilcox added this pull request to the merge queue Jun 4, 2026
Merged via the queue into main with commit 165aad8 Jun 4, 2026
218 checks passed
@chrisleewilcox chrisleewilcox deleted the MMQA-1900-stabilize-testsnaps-datetime-picker branch June 4, 2026 17:49
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.81.0 Issue or pull request that will be included in release 7.81.0 label Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

area-testSuite E2E release-7.81.0 Issue or pull request that will be included in release 7.81.0 risk:high AI analysis: high risk size-S team-qa QA team tests Test related issues

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants