test(e2e): stabilize TestSnaps date/time picker taps#31085
Conversation
Pass checkStability + elemDescription to Gestures.waitAndTap so the date, time, and date-time picker interactions wait for element stability and produce clearer failure messages. Co-Authored-By: Claude Opus 4.7 (1M context) <noreply@anthropic.com>
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 0a6a64c. Configure here.
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #31085 +/- ##
==========================================
+ Coverage 82.86% 82.99% +0.13%
==========================================
Files 5582 5605 +23
Lines 144198 144354 +156
Branches 33521 33535 +14
==========================================
+ Hits 119483 119801 +318
+ Misses 16682 16482 -200
- Partials 8033 8071 +38 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|

Description
Adds
checkStabilityandelemDescriptionoptions to theGestures.waitAndTapcalls inside the date, time, and date-time picker helpers in theTestSnapspage object. Stability checks prevent taps from firing on an element while it is still animating, and the descriptions surface clearer messages when a tap fails. No production code is affected.Changelog
CHANGELOG entry: null
Related issues
Fixes: MMQA-1900
Manual testing steps
Screenshots/Recordings
Before
N/A — test-only change.
After
Coverage is provided by CI. All four snap Android smoke shards (which exercise the affected
TestSnapshelpers) passed on this branch:snaps-android-smoke (1)— passsnaps-android-smoke (2)— passsnaps-android-smoke (3)— passsnaps-android-smoke (4)— passSee checks on this PR for the run: https://github.com/MetaMask/metamask-mobile/pull/31085/checks
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist