Skip to content

feat: add skip-pod-install input to E2E setup action and adjust timeout for iOS test-runner jobs#31072

Merged
cmd-ob merged 2 commits into
mainfrom
optimise-e2e-ci-setup
Jun 4, 2026
Merged

feat: add skip-pod-install input to E2E setup action and adjust timeout for iOS test-runner jobs#31072
cmd-ob merged 2 commits into
mainfrom
optimise-e2e-ci-setup

Conversation

@cmd-ob

@cmd-ob cmd-ob commented Jun 4, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

iOS E2E test-runner jobs were spending ~8m48s (Cirrus) and ~5m48s (Namespace) on environment setup, with the majority of that time consumed by the Ruby → Bundler → CocoaPods → pod install chain. Since iOS test-runner jobs use a pre-built .app artifact, the Pods directory is not needed — Detox 20.x does not integrate via CocoaPods and does not require ios/Pods/ to run tests.

This PR introduces a skip-pod-install input to the setup-e2e-env composite action that skips the entire Ruby/Bundler/CocoaPods chain for jobs that do not need it. The run-e2e-workflow.yml enables this for all iOS test-runner shards.

Measured impact (27 shards, Cirrus runners):

  • Setup time: 8m48s → 2m00s average (−6m48s per shard)
  • Total job time: 17m44s → 11m38s average
  • Across 27 parallel shards: ~176 minutes of compute eliminated per run

Additional changes:

  • node_modules added to the Namespace iOS cache path (mirrors existing Android config)
  • iOS Namespace setup step timeout reduced from 45 → 30 minutes (pod install no longer runs)

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

CI-only change — no app behaviour is modified. Verification is observing the Set up E2E environment step duration in the iOS smoke test shards drop from ~8–9 minutes to ~2 minutes.

Screenshots/Recordings

Before

Average iOS shard setup: 8m48s (Cirrus), 5m48s (Namespace)

After

Average iOS shard setup: 2m00s (Cirrus) — measured across 27 shards on run 26952185912

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@cmd-ob cmd-ob requested review from a team as code owners June 4, 2026 12:38
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-qa QA team label Jun 4, 2026
@github-actions github-actions Bot added size-S risk:high AI analysis: high risk labels Jun 4, 2026
cursor[bot]
cursor Bot reviewed Jun 4, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit bbfc0a2. Configure here.

Comment thread .github/workflows/run-e2e-workflow.yml Outdated
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: high
  • AI Confidence: 85%
click to see 🤖 AI reasoning details

E2E Test Selection:
These are CI infrastructure changes to the E2E test setup pipeline that affect ALL iOS E2E test runs:

  1. setup-e2e-env/action.yml: Added skip-pod-install input that, when true, bypasses all Ruby/bundler/CocoaPods installation steps. This is a significant change to the iOS setup flow — if the logic is incorrect, iOS tests could fail to run or produce false results.

  2. run-e2e-workflow.yml:

    • Now unconditionally passes skip-pod-install: true for ALL iOS jobs in this workflow
    • Reduced iOS Namespace timeout from 45→30 minutes (relying on the time saved by skipping pod install)
    • Added node_modules to the Namespace iOS cache path

The run-e2e-workflow.yml is the central reusable workflow called by ALL smoke and regression test workflows (ios and android). The skip-pod-install: true change for iOS means every iOS test job will now skip CocoaPods setup. If this optimization is broken (e.g., the pre-built app artifact isn't available, or Detox actually needs something from Pods), ALL iOS tests would fail.

Since these changes affect the CI infrastructure that runs every single E2E test tag on iOS, the safest approach is to run all available test tags to validate the pipeline still works correctly end-to-end. This is a conservative but appropriate response to wide-ranging CI infrastructure changes.

Performance Test Selection:
These changes are purely CI infrastructure optimizations (skipping CocoaPods install for pre-built iOS apps, adjusting timeouts, adding node_modules to cache). They do not affect app code, UI rendering, data loading, state management, or any runtime behavior that would impact performance metrics. No performance tests are needed.

View GitHub Actions results

@cmd-ob cmd-ob added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed no changelog required No changelog entry is required for this change labels Jun 4, 2026
@cmd-ob cmd-ob enabled auto-merge June 4, 2026 15:37
@cmd-ob cmd-ob added this pull request to the merge queue Jun 4, 2026
Merged via the queue into main with commit a2e1d82 Jun 4, 2026
226 of 227 checks passed
@cmd-ob cmd-ob deleted the optimise-e2e-ci-setup branch June 4, 2026 15:57
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.81.0 Issue or pull request that will be included in release 7.81.0 label Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@cursor cursor[bot] cursor[bot] left review comments

@pnarayanaswamy pnarayanaswamy pnarayanaswamy approved these changes

@LeVinhGithub LeVinhGithub LeVinhGithub approved these changes

@tommasini tommasini tommasini approved these changes

Assignees

No one assigned

Labels

no changelog required No changelog entry is required for this change no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.81.0 Issue or pull request that will be included in release 7.81.0 risk:high AI analysis: high risk size-S team-qa QA team

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@cmd-ob @pnarayanaswamy @LeVinhGithub @tommasini