chore: bump assets controller v8.3.1#31063
Merged
Merged
Conversation
Add a lock-state guard to the AssetsController isEnabled() callback so the controller is disabled whenever the keyring is locked, regardless of the remote feature flag value. This prevents unnecessary network activity and data hydration while the wallet is locked. Also adds unit tests covering the locked and unlocked paths, and updates the beforeEach mock state to include KeyringController so existing isEnabled tests continue to run the full flag-check path.
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection: Performance Test Selection: |
|
Review the following changes in direct dependencies. Learn more about Socket for GitHub.
|
Prithpal-Sooriya
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Changelog
CHANGELOG entry: chore: bump assets controller v8.3.1
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Medium Risk
Gating asset unify polling on keyring lock affects wallet/background behavior when locked; dependency bump may include upstream controller changes.
Overview
Bumps
@metamask/assets-controllerto ^8.3.1 (lockfile also pulls@metamask/assets-controllers108.4.0).Mobile
assetsControllerInitnow treats the unified assets path as disabled when the keyring is locked: theisEnabledcallback returnsfalseifselectIsUnlockedis false, before evaluating the assets-unify remote feature flag. When unlocked, behavior is unchanged (flag + version check).Unit tests mock
KeyringController.isUnlockedin default store state and add cases for locked vs unlockedisEnabledoutcomes.Reviewed by Cursor Bugbot for commit 1b8046b. Bugbot is set up for automated code reviews on this repo. Configure here.