Skip to content

chore(recipe-harness): remove mobile-owned harness#31056

Merged
abretonc7s merged 3 commits into
mainfrom
chore/remove-product-agentic-harness
Jun 4, 2026
Merged

chore(recipe-harness): remove mobile-owned harness#31056
abretonc7s merged 3 commits into
mainfrom
chore/remove-product-agentic-harness

Conversation

@abretonc7s

@abretonc7s abretonc7s commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

Description

Removes Mobile-owned recipe/harness tooling from the product repo. Recipe runtime ownership moves to the external Recipe v1 runner/skills overlay, so the product repo no longer carries dev-only agentic harness code.

Changes:

  • deletes scripts/perps/agentic/**
  • deletes app/core/AgenticService/**
  • removes dev-only app hooks from NavigationService and App
  • removes a:* package scripts and stale harness docs/CODEOWNERS entries
  • removes obsolete scripts/perps/validate-core-sync.sh now that perps controller code lives in Core

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: Remove mobile-owned recipe/harness tooling

  Scenario: Product harness code is fully removed
    Given the branch chore/remove-product-agentic-harness is checked out
    When the developer runs git grep for product harness and scripts/perps refs
    Then no tracked references remain (excluding generated coverage reports)
    And git diff --check reports no issues

  Scenario: External skills overlay still drives the app without product harness
    Given local skills + runner installed from the Recipe v1 overlay
    When the runner connects to the Metro/app runtime on mm-4 via the CDP bridge
    Then the wallet fixture is detected and unlocked
    And the app navigates to WalletView and a screenshot is captured
    And cleanup restores the PR-only diff with no scripts/perps/agentic path recreated

Validation details:

  • git grep confirms no tracked product harness refs remain, excluding generated coverage reports
  • git grep confirms no tracked scripts/perps refs remain
  • git diff --check clean
  • no-build harness injection check from skills overlay: install succeeds without patching package.json, no scripts/perps/agentic path recreated, static verify passes, cleanup restores the PR-only diff
  • mm-4 live proof with local skills + runner: runtime controllable through runner-owned CDP bridge, wallet fixture detected, wallet unlocked, navigated to WalletView, screenshot captured, cleanup passed
  • Not run: native build

Screenshots/Recordings

Before

After

Local validation artifact (not embeddable from CI):

/Users/deeeed/dev/metamask/metamask-mobile-4/temp/agentic/e2e-mm4-live-ready/verify/runner-live-smoke/screenshots/mobile-v1-live-smoke.png

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

@abretonc7s abretonc7s requested review from a team as code owners June 4, 2026 03:20
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-perps Perps team label Jun 4, 2026
@github-actions github-actions Bot added size-XL risk:low AI analysis: low risk labels Jun 4, 2026
@codecov-commenter

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 83.00%. Comparing base (72e26bb) to head (8e20f64).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main   #31056      +/-   ##
==========================================
+ Coverage   82.85%   83.00%   +0.14%     
==========================================
  Files        5580     5580              
  Lines      144060   143559     -501     
  Branches    33467    33348     -119     
==========================================
- Hits       119360   119154     -206     
+ Misses      16678    16410     -268     
+ Partials     8022     7995      -27     

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@github-actions github-actions Bot added risk:high AI analysis: high risk and removed risk:low AI analysis: low risk labels Jun 4, 2026
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: 100%
click to see 🤖 AI reasoning details

E2E Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/perps-controller. Running all tests.

Performance Test Selection:
Hard rule (controller-version-update): @MetaMask controller package version updated in package.json: @metamask/perps-controller. Running all tests.

View GitHub Actions results

@mm-token-exchange-service mm-token-exchange-service Bot added INVALID-PR-TEMPLATE PR's body doesn't match template and removed INVALID-PR-TEMPLATE PR's body doesn't match template labels Jun 4, 2026
@abretonc7s abretonc7s enabled auto-merge June 4, 2026 07:53
@abretonc7s abretonc7s added this pull request to the merge queue Jun 4, 2026
Merged via the queue into main with commit 79d2d70 Jun 4, 2026
231 of 233 checks passed
@abretonc7s abretonc7s deleted the chore/remove-product-agentic-harness branch June 4, 2026 11:05
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk:high AI analysis: high risk size-XL team-perps Perps team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants