CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

Medium severity

M1 — ?? yesToken.price does not fall back when bestAsk is 0

PredictGameOutcomesTab.tsx (buildMoneylineButtons):

const price = getPrice?.(yesToken.id)?.bestAsk ?? yesToken.price;

?? only falls back on null/undefined. The WebSocket layer emits bestAsk as parseFloat(change.best_ask) || 0 (WebSocketManager.ts:735), so an illiquid market / missing ask side yields bestAsk === 0, which passes through ?? and renders the button as 0¢ instead of falling back to the static token price.

The repo already solves this exact precedence with a validity guard (price > 0):

// utils/prices.ts
const isValidPrice = (price) => typeof price === 'number' && Number.isFinite(price) && price > 0;
// getPredictBuyPrice: live bestAsk > REST buy > base price

Recommend reusing isValidPrice/getPredictBuyPrice (or at least guarding bestAsk > 0) rather than re-implementing price selection inline with ??.

M2 — Hiding the footer removes the only entry point to the market "About" / info sheet

In PredictGameDetailsContent.tsx, handleInfoPress (which opens PredictGameAboutSheet with the market description) is passed only to PredictGameDetailsFooter via onInfoPress. The new logic:

const hasExtendedOutcomes = tabsEnabled && groupMap.size > 0;
const showFooter = !hasExtendedOutcomes || (claimableAmount > 0 && Boolean(onClaimPress));

means that for an extended sports market without claimable winnings the footer is hidden, and PredictGameDetailsTabsContent exposes no info button (it only wires onBetPress). Net effect: the market description / About sheet becomes unreachable in that state — a functional regression. If this is intentional, consider relocating the info affordance into the tabs/scoreboard header; otherwise the about-sheet trigger is lost.

M3 — Scoreboard spacing regression when scores are hidden (scheduled games)

PredictSportScoreboard.tsx removed the row gap and moved spacing onto the score Text elements:

- twClassName={compact ? 'w-full gap-2' : 'w-full gap-3'}
+ twClassName="w-full"
...
- twClassName={scoreWidthClass}
+ twClassName={`${scoreWidthClass} ${compact ? 'pl-2' : 'pl-3'}`}

The pl-*/pr-* padding lives on the score texts, which are rendered only when showScores is true. For scheduled/upcoming games (showScores === false), the scores aren't rendered, so with the row gap now gone there is no spacing at all between the team logos and the center status block — they sit flush. Worth verifying the scheduled-state layout against the live/score state (the screenshots only show a scored game).

M1 is fixed in a084399. The moneyline button price now uses the shared isValidPrice guard so live bestAsk must be finite and > 0 before overriding the static token price. Added coverage for bestAsk: 0 falling back to the token price.

🔍 Smart E2E Test Selection

• Selected E2E tags: SmokePredictions, SmokeWalletPlatform, SmokeConfirmations
• Selected Performance tags: @PerformancePredict
• Risk Level: medium
• AI Confidence: 88%

View GitHub Actions results