Description

Previously, the push onboarding sheets could trigger analytics.optIn() when MetaMetrics was off, effectively using the marketing-consent flow to enable MetaMetrics in a less than clear way. This is not desired. This PR simplifies the action taken after accepting the push pre-prompt. It reduces the risk of the existing code.

This PR:

• Adds a isMetaMetricsEnabled gate in usePushPrePromptVariant so the marketing_consent variant is never returned when MetaMetrics is off (the push_permission variant is unaffected)
• Strips analytics.optIn(), updateCachedConsent(), and the device/user-settings trait generation from useEnableMarketingConsent — the hook now only operates when MetaMetrics is already on
• Removes is_metrics_opted_in from the ANALYTICS_PREFERENCE_SELECTED event property, since this flow no longer touches metrics opt-in state
• Adds test coverage for the missing push×MetaMetrics×dataCollection combinations

Changelog

CHANGELOG entry: Remove the ability for the push onboarding flow to toggle MetaMetrics opt-in state.

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

• I've followed MetaMask Contributor Docs and MetaMask Mobile Coding Standards.
• I've completed the PR template to the best of my ability
• I've included tests if applicable
• I've documented my code using JSDoc format if applicable
• I've applied the right labels on the PR (see labeling guidelines). Not required for external contributors.

Performance checks (if applicable)

• I've tested on Android
  • Ideally on a mid-range device; emulator is acceptable
• I've tested with a power user scenario
  • Use these power-user SRPs to import wallets with many accounts and tokens
• I've instrumented key operations with Sentry traces for production performance metrics
  • See trace() for usage and addToken for an example

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

• I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
• I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.