Skip to content

chore(runway): cherry-pick ci: add rc-freeze label to skip auto RC builds cp-7.80.0#31024

Merged
sleepytanya merged 1 commit into
release/7.80.0from
runway-cherry-pick-7.80.0-1780500724
Jun 3, 2026
Merged

chore(runway): cherry-pick ci: add rc-freeze label to skip auto RC builds cp-7.80.0#31024
sleepytanya merged 1 commit into
release/7.80.0from
runway-cherry-pick-7.80.0-1780500724

Conversation

@runway-github

@runway-github runway-github Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

Adds an rc-freeze label gate to the auto RC build workflow
(build-rc-auto.yml).

Why: During the final stage of a release cycle — after QA has signed
off and the last cherry-pick has landed — the release branch is being
prepared to merge into stable. At this point, it's undesirable for
every new push to trigger a fresh RC build (version bump commit +
iOS/Android builds). Previously there was no way to stop the automation
without disabling the entire workflow.

What: When the rc-freeze label is present on the release PR, the
validate-and-find-pr job emits rc-frozen=true and all downstream
jobs (generate_rc_build_version, update_rc_build_version, iOS build,
Android build) are skipped via an updated if: condition. A
::notice:: annotation is printed so the skip is visible in the Actions
log. Removing the label resumes normal auto RC builds immediately on the
next push.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Made with Cursor


Note

Low Risk
CI-only workflow gating with no app, auth, or data-path changes;
mistaken label use only delays RC builds until removed.

Overview
Adds an rc-freeze label on the release PR as a manual switch to
stop automatic RC builds on pushes to release/*, without disabling
the whole workflow.

The validate-and-find-pr job now loads PR labels, sets a
rc-frozen output when rc-freeze is present (with a
::notice:: in the Actions log), and downstream jobs—version
bump
, commit build version, and iOS/Android RC triggers—only
run when there is an associated PR and RC is not frozen. Removing
the label restores the previous behavior on the next push.

Reviewed by Cursor Bugbot for commit
35b8017. Bugbot is set up for automated
code reviews on this repo. Configure
here.

[c5fc35d](https://github.com/MetaMask/metamask-mobile/commit/c5fc35d7615d3f4b4ff0bcc96fd45c1ede852be1)

…ilds cp-7.80.0 (#30942)

## **Description**

<!--
Write a short description of the changes included in this pull request,
also include relevant motivation and context. Have in mind the following
questions:
1. What is the reason for the change?
2. What is the improvement/solution?
-->

Adds an `rc-freeze` label gate to the auto RC build workflow
(`build-rc-auto.yml`).

**Why:** During the final stage of a release cycle — after QA has signed
off and the last cherry-pick has landed — the release branch is being
prepared to merge into `stable`. At this point, it's undesirable for
every new push to trigger a fresh RC build (version bump commit +
iOS/Android builds). Previously there was no way to stop the automation
without disabling the entire workflow.

**What:** When the `rc-freeze` label is present on the release PR, the
`validate-and-find-pr` job emits `rc-frozen=true` and all downstream
jobs (`generate_rc_build_version`, `update_rc_build_version`, iOS build,
Android build) are skipped via an updated `if:` condition. A
`::notice::` annotation is printed so the skip is visible in the Actions
log. Removing the label resumes normal auto RC builds immediately on the
next push.

## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry: null

## **Related issues**

Fixes:

## **Manual testing steps**

N/A

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

N/A

### **After**

N/A

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [x] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [x] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [x] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [ ] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.

<!-- Generated with the help of the pr-description AI skill -->

Made with [Cursor](https://cursor.com)

<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Low Risk**
> CI-only workflow gating with no app, auth, or data-path changes;
mistaken label use only delays RC builds until removed.
> 
> **Overview**
> Adds an **`rc-freeze`** label on the release PR as a manual switch to
**stop automatic RC builds** on pushes to `release/*`, without disabling
the whole workflow.
> 
> The **`validate-and-find-pr`** job now loads PR **labels**, sets a
**`rc-frozen`** output when `rc-freeze` is present (with a
**`::notice::`** in the Actions log), and downstream jobs—**version
bump**, **commit build version**, and **iOS/Android RC triggers**—only
run when there is an associated PR **and** RC is not frozen. Removing
the label restores the previous behavior on the next push.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
35b8017. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->
@runway-github runway-github Bot requested a review from a team as a code owner June 3, 2026 15:32
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Jun 3, 2026
@github-actions github-actions Bot added the size-S label Jun 3, 2026
@sleepytanya sleepytanya merged commit e036872 into release/7.80.0 Jun 3, 2026
154 of 156 checks passed
@sleepytanya sleepytanya deleted the runway-cherry-pick-7.80.0-1780500724 branch June 3, 2026 19:57
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-S team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants