Skip to content

fix: make "Check TestFlight" text a clickable link in Slack RC notifications#31018

Merged
sleepytanya merged 2 commits into
mainfrom
add-testflight-link
Jun 3, 2026
Merged

fix: make "Check TestFlight" text a clickable link in Slack RC notifications#31018
sleepytanya merged 2 commits into
mainfrom
add-testflight-link

Conversation

@sleepytanya

@sleepytanya sleepytanya commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

Make "Check TestFlight" text a clickable link in Slack RC notifications.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

Screenshot 2026-06-03 at 10 40 17 AM

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Only changes fallback Slack mrkdwn text in a non-blocking RC notification script; no app runtime, auth, or data handling impact.

Overview
When the RC Slack notification has no valid iOS download URL, the iOS row no longer shows plain italic “Check TestFlight”. It now uses a Slack mrkdwn link to the public TestFlight join URL (https://testflight.apple.com/join/hBrjtFuA), matching how Android shows a clickable “Download” when a URL exists.

Reviewed by Cursor Bugbot for commit 5b2a2a5. Bugbot is set up for automated code reviews on this repo. Configure here.

@sleepytanya sleepytanya requested a review from a team as a code owner June 3, 2026 14:46
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. label Jun 3, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added the team-qa QA team label Jun 3, 2026
@sleepytanya sleepytanya added team-release release-7.81.0 Issue or pull request that will be included in release 7.81.0 No QA Needed Apply this label when your PR does not need any QA effort. and removed team-qa QA team pr-not-ready-for-e2e Skip E2E and block merging. Remove this label once the PR is ready to run the E2E tests. labels Jun 3, 2026
@sleepytanya sleepytanya enabled auto-merge June 3, 2026 14:47
@sleepytanya sleepytanya changed the title Make "Check TestFlight" text a clickable link in Slack RC notifications fix: make "Check TestFlight" text a clickable link in Slack RC notifications Jun 3, 2026

@baptiste-marchand baptiste-marchand left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

approving to unblock engagement CO requirement

@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: None (no tests recommended)
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 99%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only change is in scripts/slack-rc-notification.mjs, a Slack notification script used for release candidate announcements. The modification converts a plain text fallback for the iOS build URL into a hyperlink to the TestFlight page. This is purely a CI/notification infrastructure change with zero impact on app code, user flows, E2E test infrastructure, or performance-sensitive paths. No E2E tests are warranted.

Performance Test Selection:
This change only modifies a Slack notification script (formatting a URL as a hyperlink). There is no impact on app rendering, data loading, state management, or any performance-sensitive code path.

View GitHub Actions results

@sleepytanya sleepytanya added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit ec02b01 Jun 3, 2026
155 of 157 checks passed
@sleepytanya sleepytanya deleted the add-testflight-link branch June 3, 2026 16:31
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

No QA Needed Apply this label when your PR does not need any QA effort. release-7.81.0 Issue or pull request that will be included in release 7.81.0 size-XS team-release

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants