chore(runway): cherry-pick fix(fingerprint): exclude JS-only changes from EAS fingerprint#31013
Merged
Merged
Conversation
…from EAS fingerprint (#30332) ## **Description** The EAS fingerprint was being invalidated by JS-only changes (e.g. `@metamask/*-controller` version bumps, `package.json` `scripts`/`version` edits, and JS-only yarn patches), forcing unnecessary native rebuilds and blocking OTA updates. This change makes the fingerprint reflect only native-relevant inputs: - Resolves the set of packages with native code via Expo autolinking (`yarn expo-modules-autolinking resolve` for iOS and Android), with a safe fallback to hashing everything if resolution fails. - Adds a `fileHookTransform` that filters `package.json` down to the `dependencies`/`devDependencies` of native packages (plus `expo` autolinking overrides), and excludes `.yarn/patches` for JS-only packages. - Removes the static `.yarn/patches` `extraSource` and the now-redundant `.fingerprintignore`, since patch filtering is handled in the transform. Note: the transform buffers `package.json` across streamed chunks before parsing, since `fileHookTransform` is invoked per-chunk. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: EAS fingerprint excludes JS-only changes Scenario: JS-only dependency bump does not change the fingerprint Given a clean working tree When I run "yarn fingerprint:generate" and record the hash And I bump a JS-only dependency version in package.json And I run "yarn fingerprint:generate" again Then the hash is unchanged Scenario: native dependency bump changes the fingerprint Given a clean working tree When I bump a native dependency version in package.json And I run "yarn fingerprint:generate" Then the hash differs from the baseline ```
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
vpintorico
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
The EAS fingerprint was being invalidated by JS-only changes (e.g.
@metamask/*-controllerversion bumps,package.jsonscripts/versionedits, and JS-only yarn patches), forcingunnecessary native rebuilds and blocking OTA updates.
This change makes the fingerprint reflect only native-relevant inputs:
(
yarn expo-modules-autolinking resolvefor iOS and Android), with asafe fallback to hashing everything if resolution fails.
fileHookTransformthat filterspackage.jsondown to thedependencies/devDependenciesof native packages (plusexpoautolinking overrides), and excludes
.yarn/patchesfor JS-onlypackages.
.yarn/patchesextraSourceand the now-redundant.fingerprintignore, since patch filtering is handled in the transform.Note: the transform buffers
package.jsonacross streamed chunks beforeparsing, since
fileHookTransformis invoked per-chunk.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps