Skip to content

chore(runway): cherry-pick ci: remove OTA tag creation step#31012

Merged
tommasini merged 1 commit into
release/7.80.0from
runway-cherry-pick-7.80.0-1780490200
Jun 3, 2026
Merged

chore(runway): cherry-pick ci: remove OTA tag creation step#31012
tommasini merged 1 commit into
release/7.80.0from
runway-cherry-pick-7.80.0-1780490200

Conversation

@runway-github

@runway-github runway-github Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

Remove OTA publishing and release-tag creation from the automated/Runway
CI flows. OTA updates are now published and tagged manually in Runway,
so CI only needs to detect OTA bumps (to skip native builds) and
otherwise build.

Changes

auto-rc-ota-build-core.yml (Auto RC build/OTA core)

  • Removed the trigger-ota job (no longer pushes EAS OTA updates via
    push-eas-update.yml).
  • Removed the validate-ota-pr job (only existed to guard the OTA push).
  • Removed the create-ota-production-tag job and the
    create_production_ota_tag + ota_channel inputs.
  • Kept OTA detection: resolve-context still runs and trigger-build
    remains gated on ota_bump != 'true', so OTA-only branches skip the
    native build instead of building.
  • Tightened permissions from contents: write + actions: write +
    pull-requests: read + id-token: write down to contents: read +
    pull-requests: read + id-token: write.

runway-ota-production.yml (Runway OTA Production)

  • Removed the create-ota-production-tag job — the v<OTA_VERSION> tag is
    now created manually in Runway.
  • Tightened permissions contents: write → contents: read (write was only
    needed to push the tag).
  • Updated header comment + source_branch input description.

runway-create-ota-production-tag.yml

Deleted — it was the reusable tag-creation workflow and is no longer
referenced by any caller after the changes above.

Changelog

CHANGELOG entry:null

Related issues

Fixes:

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
  • Use these power-user
    SRPs

    to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production
    performance metrics
  • See trace() for usage and
    addToken
    for an example

For performance guidelines and tooling, see the Performance
Guide
.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the
    app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described
    in the ticket it closes and includes the necessary testing evidence such
    as recordings and or screenshots.

Note

Medium Risk
Changes release automation boundaries—OTA-only RC pushes will skip
native builds without CI publishing OTA, so Runway/manual steps must
stay in sync or releases can stall.

Overview
CI no longer publishes EAS OTA updates or creates v<OTA_VERSION>
release tags; those steps move to manual Runway handling.

auto-rc-ota-build-core.yml drops trigger-ota,
validate-ota-pr, and create-ota-production-tag, plus inputs
ota_channel and create_production_ota_tag. It still runs
resolve-context and only runs native build.yml (and TestFlight
on iOS) when ota_bump != 'true', so OTA-only commits skip binaries.
Permissions are reduced to contents: read (no tag push or workflow
dispatch for OTA).

runway-ota-production.yml still pushes production OTA via
push-eas-update.yml but no longer creates the production release tag.
runway-create-ota-production-tag.yml is deleted.

Reviewed by Cursor Bugbot for commit
0a209ff. Bugbot is set up for automated
code reviews on this repo. Configure
here.

Co-authored-by: João Loureiro 175489935+joaoloureirop@users.noreply.github.com c6cc0b9

## **Description**
Remove OTA publishing and release-tag creation from the automated/Runway
CI flows. OTA updates are now published and tagged manually in Runway,
so CI only needs to detect OTA bumps (to skip native builds) and
otherwise build.

**Changes**

**auto-rc-ota-build-core.yml (Auto RC build/OTA core)**

- Removed the trigger-ota job (no longer pushes EAS OTA updates via
push-eas-update.yml).
- Removed the validate-ota-pr job (only existed to guard the OTA push).
- Removed the create-ota-production-tag job and the
create_production_ota_tag + ota_channel inputs.
- Kept OTA detection: resolve-context still runs and trigger-build
remains gated on ota_bump != 'true', so OTA-only branches skip the
native build instead of building.
- Tightened permissions from contents: write + actions: write +
pull-requests: read + id-token: write down to contents: read +
pull-requests: read + id-token: write.

**runway-ota-production.yml (Runway OTA Production)**

- Removed the create-ota-production-tag job — the v<OTA_VERSION> tag is
now created manually in Runway.
- Tightened permissions contents: write → contents: read (write was only
needed to push the tag).
- Updated header comment + source_branch input description.

**runway-create-ota-production-tag.yml**

Deleted — it was the reusable tag-creation workflow and is no longer
referenced by any caller after the changes above.


## **Changelog**

<!--
If this PR is not End-User-Facing and should not show up in the
CHANGELOG, you can choose to either:
1. Write `CHANGELOG entry: null`
2. Label with `no-changelog`

If this PR is End-User-Facing, please write a short User-Facing
description in the past tense like:
`CHANGELOG entry: Added a new tab for users to see their NFTs`
`CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker`

(This helps the Release Engineer do their job more quickly and
accurately)
-->

CHANGELOG entry:null

## **Related issues**

Fixes:

## **Manual testing steps**

```gherkin
Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]
```

## **Screenshots/Recordings**

<!-- If applicable, add screenshots and/or recordings to visualize the
before and after of your change. -->

### **Before**

<!-- [screenshots/recordings] -->

### **After**

<!-- [screenshots/recordings] -->

## **Pre-merge author checklist**

<!--
Every checklist item must be consciously assessed before marking this PR
as
"Ready for review". A checked box means you deliberately considered that
responsibility, not that you literally performed every action listed.

Unchecked boxes are ambiguous: they are not an implicit "N/A" and they
are not
a silent "skip". See `docs/readme/ready-for-review.md` for the full
checklist
semantics.
-->

- [x] I've followed [MetaMask Contributor
Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile
Coding
Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md).
- [x] I've completed the PR template to the best of my ability
- [x] I've included tests if applicable
- [x] I've documented my code using [JSDoc](https://jsdoc.app/) format
if applicable
- [x] I've applied the right labels on the PR (see [labeling
guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)).
Not required for external contributors.

#### Performance checks (if applicable)

- [ ] I've tested on Android
  - Ideally on a mid-range device; emulator is acceptable
- [ ] I've tested with a power user scenario
- Use these [power-user
SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93)
to import wallets with many accounts and tokens
- [ ] I've instrumented key operations with Sentry traces for production
performance metrics
- See [`trace()`](/app/util/trace.ts) for usage and
[`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274)
for an example

For performance guidelines and tooling, see the [Performance
Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers).

## **Pre-merge reviewer checklist**

<!--
Reviewer checklist items follow the same semantics as the author
checklist: an
unchecked box is ambiguous, a checked box means the reviewer consciously
assessed that responsibility. See `docs/readme/ready-for-review.md`.
-->

- [ ] I've manually tested the PR (e.g. pull and build branch, run the
app, test code being changed).
- [x] I confirm that this PR addresses all acceptance criteria described
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.


<!-- CURSOR_SUMMARY -->
---

> [!NOTE]
> **Medium Risk**
> Changes release automation boundaries—OTA-only RC pushes will skip
native builds without CI publishing OTA, so Runway/manual steps must
stay in sync or releases can stall.
> 
> **Overview**
> CI no longer publishes EAS OTA updates or creates `v<OTA_VERSION>`
release tags; those steps move to manual Runway handling.
> 
> **`auto-rc-ota-build-core.yml`** drops `trigger-ota`,
`validate-ota-pr`, and `create-ota-production-tag`, plus inputs
`ota_channel` and `create_production_ota_tag`. It still runs
`resolve-context` and only runs native **`build.yml`** (and TestFlight
on iOS) when `ota_bump != 'true'`, so OTA-only commits skip binaries.
Permissions are reduced to `contents: read` (no tag push or workflow
dispatch for OTA).
> 
> **`runway-ota-production.yml`** still pushes production OTA via
`push-eas-update.yml` but no longer creates the production release tag.
**`runway-create-ota-production-tag.yml`** is deleted.
> 
> <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit
0a209ff. Bugbot is set up for automated
code reviews on this repo. Configure
[here](https://www.cursor.com/dashboard/bugbot).</sup>
<!-- /CURSOR_SUMMARY -->

Co-authored-by: João Loureiro <175489935+joaoloureirop@users.noreply.github.com>
@runway-github runway-github Bot requested a review from a team as a code owner June 3, 2026 12:36
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-bots Bot team (for MetaMask Bot, Runway Bot, etc.) label Jun 3, 2026
@github-actions github-actions Bot added the size-M label Jun 3, 2026
@tommasini tommasini merged commit 525535f into release/7.80.0 Jun 3, 2026
84 checks passed
@tommasini tommasini deleted the runway-cherry-pick-7.80.0-1780490200 branch June 3, 2026 12:45
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

size-M team-bots Bot team (for MetaMask Bot, Runway Bot, etc.)

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants