Skip to content

feat: design fixes in perps / predict transactions using money balance#30999

Merged
jpuri merged 101 commits into
mainfrom
money_acc_fixes
Jun 4, 2026
Merged

feat: design fixes in perps / predict transactions using money balance#30999
jpuri merged 101 commits into
mainfrom
money_acc_fixes

Conversation

@jpuri

@jpuri jpuri commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

Description

Design fixes of perps / predict money account transactions.

Changelog

CHANGELOG entry:

Related issues

Fixes: https://consensyssoftware.atlassian.net/browse/CONF-1476

Manual testing steps

Feature: my feature name

  Scenario: user [verb for user action]
    Given [describe expected initial app state]

    When user [verb for user action]
    Then [describe expected outcome]

Screenshots/Recordings

Screen.Recording.2026-06-03.at.4.29.27.PM.mov

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Presentation and i18n changes in confirmation pay-with UI; payment override behavior is unchanged aside from consistent "available" subtitle copy.

Overview
Aligns perps / predict confirmation flows that pay from a money account with updated design: copy is Money balance (not Money account / mUSD), the pay-with bottom sheet omits the money section header, and balance is shown as a subtitle ($X available) for all supported money-account transaction types—not only deposits.

Pay-with row (money override): uses a shared money.png icon instead of the token icon, drops the inline fiat balance next to the label, and updates design-system arrow icon colors.

Pay-with section only renders the uppercase section title when config.title is non-empty.

Locale key confirm.pay_with_bottom_sheet.money_account is renamed to money_balance.

Reviewed by Cursor Bugbot for commit bc872d2. Bugbot is set up for automated code reviews on this repo. Configure here.

@jpuri jpuri added team-confirmations Push issues to confirmations team no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed labels Jun 3, 2026
@github-actions

github-actions Bot commented Jun 3, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@github-actions github-actions Bot added the size-M label Jun 3, 2026
@jpuri jpuri marked this pull request as ready for review June 3, 2026 11:02
@jpuri jpuri requested a review from a team as a code owner June 3, 2026 11:02
@OGPoyraz OGPoyraz requested a review from vinistevam June 3, 2026 15:00
vinistevam
vinistevam previously approved these changes Jun 3, 2026
Base automatically changed from perps_withdraw_money_acc to main June 4, 2026 08:59
@jpuri jpuri dismissed vinistevam’s stale review June 4, 2026 08:59

The base branch was changed.

@jpuri jpuri enabled auto-merge June 4, 2026 09:23
@github-actions github-actions Bot added the risk:high AI analysis: high risk label Jun 4, 2026
@jpuri jpuri requested a review from vinistevam June 4, 2026 09:23
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeAccounts, SmokeConfirmations, SmokeIdentity, SmokeNetworkAbstractions, SmokeNetworkExpansion, SmokeSwap, SmokeStake, SmokeWalletPlatform, SmokeMoney, SmokePerps, SmokeMultiChainAPI, SmokePredictions, SmokeSeedlessOnboarding, SmokeBrowser, SmokeSnaps
  • Selected Performance tags: @PerformanceAccountList, @PerformanceOnboarding, @PerformanceLogin, @PerformanceSwaps, @PerformanceLaunch, @PerformanceAssetLoading, @PerformancePredict, @PerformancePreps
  • Risk Level: high
  • AI Confidence: %
click to see 🤖 AI reasoning details

E2E Test Selection:
Fallback: AI analysis did not complete successfully. Running all tests.

Performance Test Selection:
Fallback: AI analysis did not complete successfully. Running all performance tests.

View GitHub Actions results

@jpuri jpuri added the skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. label Jun 4, 2026
@jpuri jpuri added this pull request to the merge queue Jun 4, 2026
Merged via the queue into main with commit dbca316 Jun 4, 2026
586 of 598 checks passed
@jpuri jpuri deleted the money_acc_fixes branch June 4, 2026 11:24
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.81.0 Issue or pull request that will be included in release 7.81.0 label Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.81.0 Issue or pull request that will be included in release 7.81.0 risk:high AI analysis: high risk size-M skip-sonar-cloud Only used for bypassing sonar cloud when failures are not relevant to the changes. team-confirmations Push issues to confirmations team

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants