feat(predict): Refine Bottom Sheet small UI Tweaks#30979
Merged
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
No logic changes, no controller changes, no shared component changes, no API changes. Risk is low. Tag selection:
Performance Test Selection: |
caieu
approved these changes
Jun 3, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Small set of UI polish tweaks to the Predict buy bottom sheet (sheet mode of
PredictBuyWithAnyToken), based on design feedback on spacing and alignment.What changed and why:
px-6 py-4, so the market icon (left) and the closeX(right) were inset 24px while the content/pills below are inset 16px, making them look misaligned. Changed the header topx-4 py-4so the icon's left padding equals its top padding and both the icon andXline up with the pills and rows beneath them.lineHeight - 4, ~66px for$0), making it taller than the digits and sitting a little far from the number. It now matches the glyph cap height (fontSize * 0.72) and sits closer (px-1on the value text,ml-0on the caret).py-2->py-1, and pill heighth-12->h-11(44px, kept at the iOS minimum touch target). The pills remain edge-aligned with the pay-with/total rows via the sharedpx-4inset.PredictFeeSummary'spb-6, 20px below from its ownmb-5). Added-mt-1so the top gap becomes 20px and matches the bottom gap, with a comment documenting the intent so it isn't a "magic" offset.These are presentational (Tailwind class) changes only — no logic, data flow, or control flow was modified.
Files changed:
app/components/UI/Predict/components/PredictPreviewSheet/PredictPreviewSheet.tsxapp/components/UI/Predict/components/PredictAmountDisplay/PredictAmountDisplay.tsxapp/components/UI/Predict/views/PredictBuyWithAnyToken/components/PredictQuickAmounts/PredictQuickAmounts.tsxapp/components/UI/Predict/views/PredictBuyWithAnyToken/components/PredictBuyErrorBanner/PredictBuyErrorBanner.tsx(4 files changed, 12 insertions(+), 6 deletions(-))
Note on shared components:
PredictPreviewSheetis also used by the Predict sell sheet, andPredictAmountDisplayis also used by the legacy/fullscreen buy preview — so the header padding and caret tweaks apply consistently to those surfaces too.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an examplePre-merge reviewer checklist
Validation run locally
yarn lint(eslint): 0 errors (2 pre-existing deprecation warnings on unchanged lines).yarn lint:tsc(tsc --noEmit): passes, 0 type errors.PredictAmountDisplay,PredictPreviewSheet,PredictBuyErrorBanner,PredictQuickAmounts).Note
Low Risk
Presentational Tailwind/class tweaks only; no auth, data, or business-logic changes.
Overview
Polishes Predict buy/sell preview bottom sheet layout so header, amount entry, quick amounts, and error states line up with design spacing.
PredictPreviewSheetheader horizontal padding goes frompx-6topx-4so the market icon and close control align with the 16px-inset content below (also affects sell sheet and other consumers of this shared header).PredictAmountDisplaytightens amount typography spacing (px-2→px-1) and resizes the blinking caret from line-height-based height tofontSize * 0.72, withml-0so the caret matches digit cap height and sits closer to the value (shared with fullscreen buy preview).PredictQuickAmountsreduces vertical padding (py-2→py-1) and pill height (h-12→h-11, still ≥44px touch target).PredictBuyErrorBanneradds-mt-1(documented) to balance 20px gaps above/below the banner relative toPredictFeeSummary’spb-6.All changes are Tailwind/class-only; no logic or data flow changes.
Reviewed by Cursor Bugbot for commit 9849b1b. Bugbot is set up for automated code reviews on this repo. Configure here.