chore(runway): cherry-pick ci(runway-ota): add actions: read permission for slack notification cp-7.79.1 cp-7.80.0#30976
Merged
Conversation
…sion for slack notification cp-7.79.1 cp-7.80.0 (#30973) ## **Description** <!-- Write a short description of the changes included in this pull request, also include relevant motivation and context. Have in mind the following questions: 1. What is the reason for the change? 2. What is the improvement/solution? --> The `runway-ota-rc.yml` caller workflow was missing the `actions: read` permission required by the `slack-rc-notification.yml` reusable workflow. GitHub Actions enforces that a reusable workflow cannot use permissions that the calling workflow has not already granted. `slack-rc-notification.yml` declares `actions: read` (needed by `actions/download-artifact@v4` to download the Android Play Store check report), but `runway-ota-rc.yml` only granted `contents: read`, `pull-requests: read`, and `id-token: write`. This caused the workflow validation step to fail with: > Error calling workflow '…slack-rc-notification.yml…'. The workflow is requesting 'actions: read', but is only allowed 'actions: none'. The fix adds `actions: read` to the `permissions` block in `runway-ota-rc.yml`. ## **Changelog** CHANGELOG entry: null ## **Related issues** Fixes: ## **Manual testing steps** N/A ## **Screenshots/Recordings** ### **Before** N/A ### **After** N/A ## **Pre-merge author checklist** - [x] I've followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [x] I've completed the PR template to the best of my ability - [x] I've included tests if applicable - [x] I've documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [x] I've applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. #### Performance checks (if applicable) - [x] I've tested on Android - Ideally on a mid-range device; emulator is acceptable - [x] I've tested with a power user scenario - Use these [power-user SRPs](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/edit-v2/401401446401?draftShareId=9d77e1e1-4bdc-4be1-9ebb-ccd916988d93) to import wallets with many accounts and tokens - [x] I've instrumented key operations with Sentry traces for production performance metrics - See [`trace()`](/app/util/trace.ts) for usage and [`addToken`](/app/components/Views/AddAsset/components/AddCustomToken/AddCustomToken.tsx#L274) for an example For performance guidelines and tooling, see the [Performance Guide](https://consensyssoftware.atlassian.net/wiki/spaces/TL1/pages/400085549067/Performance+Guide+for+Engineers). ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. Made with [Cursor](https://cursor.com) <!-- CURSOR_SUMMARY --> --- > [!NOTE] > **Low Risk** > Single CI permission line; no app, auth, or release logic changes. > > **Overview** > Grants **`actions: read`** on the **Runway OTA RC** caller workflow so it can invoke **`slack-rc-notification.yml`** without GitHub rejecting the run. > > Reusable workflows only get permissions the caller explicitly allows; the Slack workflow needs **`actions: read`** for **`actions/download-artifact@v4`** (Android Play Store check report). Without this line, validation fails with *actions: none* vs *actions: read*. > > <sup>Reviewed by [Cursor Bugbot](https://cursor.com/bugbot) for commit d8d24e7. Bugbot is set up for automated code reviews on this repo. Configure [here](https://www.cursor.com/dashboard/bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
actions: readpermission for slack notification cp-7.79.1 cp-7.80.0 (ci(runway-ota): addactions: readpermission for slack notification cp-7.79.1 cp-7.80.0 #30973)Description
The
runway-ota-rc.ymlcaller workflow was missing theactions: readpermission required by the
slack-rc-notification.ymlreusableworkflow.
GitHub Actions enforces that a reusable workflow cannot use permissions
that the calling workflow has not already granted.
slack-rc-notification.ymldeclaresactions: read(needed byactions/download-artifact@v4to download the Android Play Store checkreport), but
runway-ota-rc.ymlonly grantedcontents: read,pull-requests: read, andid-token: write. This caused the workflowvalidation step to fail with:
The fix adds
actions: readto thepermissionsblock inrunway-ota-rc.yml.Changelog
CHANGELOG entry: null
Related issues
Fixes:
Manual testing steps
N/A
Screenshots/Recordings
Before
N/A
After
N/A
Pre-merge author checklist
Docs and MetaMask Mobile
Coding
Standards.
if applicable
guidelines).
Not required for external contributors.
Performance checks (if applicable)
SRPs
to import wallets with many accounts and tokens
performance metrics
trace()for usage andaddTokenfor an example
For performance guidelines and tooling, see the Performance
Guide.
Pre-merge reviewer checklist
app, test code being changed).
in the ticket it closes and includes the necessary testing evidence such
as recordings and or screenshots.
Made with Cursor
Note
Low Risk
Single CI permission line; no app, auth, or release logic changes.
Overview
Grants
actions: readon the Runway OTA RC caller workflow soit can invoke
slack-rc-notification.ymlwithout GitHub rejectingthe run.
Reusable workflows only get permissions the caller explicitly allows;
the Slack workflow needs
actions: readforactions/download-artifact@v4(Android Play Store check report).Without this line, validation fails with actions: none vs actions:
read.
Reviewed by Cursor Bugbot for commit
d8d24e7. Bugbot is set up for automated
code reviews on this repo. Configure
here.