Skip to content

fix(MUSD-880): update link card description #30967

Merged
shane-t merged 5 commits into
mainfrom
shane-t/MUSD-880
Jun 3, 2026
Merged

fix(MUSD-880): update link card description #30967
shane-t merged 5 commits into
mainfrom
shane-t/MUSD-880

Conversation

@shane-t

@shane-t shane-t commented Jun 2, 2026

Copy link
Copy Markdown
Member

Description

The description copy shown in the "Link your MetaMask Card" stepper step and the card link section on the Money home screen was verbose and referenced APY in a way that could be confusing. This PR updates four i18n strings in en.json to the approved copy: "Spend your balance and earn on purchases." — applied to both the virtual and metal card onboarding step descriptions, and the link_subtitle / link_subtitle_no_apy keys in the metamask_card section.

Changelog

CHANGELOG entry: null

Related issues

Fixes: MUSD-880

Manual testing steps

Feature: Link card section description copy

  Scenario: User views the card onboarding step (no card yet)
    Given the user is on the Money tab
    And the onboarding stepper is on step 2 (Get your MetaMask Card)

    When they view the step description
    Then it reads "Spend your balance and earn on purchases."

  Scenario: User views the card onboarding step (card linked but not linked to Money)
    Given the user has a MetaMask Card but it is not linked to Money
    And they are on the Money tab

    When they view the step 2 description
    Then it reads "Spend your balance and earn on purchases."

  Scenario: User views the Link MetaMask Card section on Money home
    Given the user is on the Money tab
    And the milestone state shows the link card section

    When they view the subtitle under "Link MetaMask Card"
    Then it reads "Spend your balance and earn on purchases."

Screenshots/Recordings

Before

Simulator Screenshot - iPhone 16e - 2026-06-02 at 21 22 55

After

Simulator Screenshot - iPhone 16e - 2026-06-02 at 21 23 43

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
User-visible string changes only in en.json and tests; no logic or security impact.

Overview
Updates English copy for MetaMask Card “link” and Money onboarding surfaces so messaging is shorter and less APY-heavy.

Onboarding (step 2) descriptions for both “no card” and “unlinked card” now use “Spend your balance and earn on purchases.” instead of the longer Mastercard / earn-while-it-earns wording.

Link card UI (money.metamask_card): link_subtitle and link_subtitle_no_apy both use that same line (the subtitle no longer embeds APY). The APY bullet adds a ~ prefix: “Earn up to ~{{apy}}% APY (variable)”.

Tests in CardHome.test.tsx and MoneyMetaMaskCard.test.tsx are aligned with the new strings; the no-APY link-mode test drops a redundant absence check now that subtitle keys share identical copy.

Reviewed by Cursor Bugbot for commit 1c50530. Bugbot is set up for automated code reviews on this repo. Configure here.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-mobile-ux Mobile UX team label Jun 2, 2026
@shane-t shane-t changed the title fix(MUSD-880): update link card description to 'Spend your balance an… fix(MUSD-880): update link card description Jun 2, 2026
@shane-t shane-t added team-earn and removed team-mobile-ux Mobile UX team labels Jun 2, 2026
@github-actions github-actions Bot added size-S and removed size-XS labels Jun 2, 2026
@shane-t shane-t marked this pull request as ready for review June 2, 2026 20:24
@shane-t shane-t requested a review from a team as a code owner June 2, 2026 20:24

@cursor cursor Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit e3a7116. Configure here.

Comment thread locales/languages/en.json
@github-actions github-actions Bot added the risk:medium AI analysis: medium risk label Jun 2, 2026
@shane-t shane-t requested a review from a team as a code owner June 2, 2026 21:05
@github-actions github-actions Bot added risk:low AI analysis: low risk and removed risk:medium AI analysis: medium risk labels Jun 2, 2026
Matt561
Matt561 previously approved these changes Jun 2, 2026
@shane-t shane-t requested a review from Matt561 June 3, 2026 13:44
@shane-t shane-t added this pull request to the merge queue Jun 3, 2026
Merged via the queue into main with commit c5ac8b9 Jun 3, 2026
105 checks passed
@shane-t shane-t deleted the shane-t/MUSD-880 branch June 3, 2026 14:37
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 3, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.81.0 Issue or pull request that will be included in release 7.81.0 label Jun 3, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

release-7.81.0 Issue or pull request that will be included in release 7.81.0 risk:low AI analysis: low risk size-S team-earn

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants