Skip to content

chore: bump @metamask/bitcoin-wallet-snap to ^1.12.0#30958

Merged
jeremytsng merged 1 commit into
mainfrom
chore/bump-bitcoin-wallet-snap-1.12.0
Jun 4, 2026
Merged

chore: bump @metamask/bitcoin-wallet-snap to ^1.12.0#30958
jeremytsng merged 1 commit into
mainfrom
chore/bump-bitcoin-wallet-snap-1.12.0

Conversation

@jeremytsng

@jeremytsng jeremytsng commented Jun 2, 2026 •
edited by cursor Bot
Loading

Copy link
Copy Markdown
Contributor

Description

Bumps the bundled Bitcoin wallet Snap (@metamask/bitcoin-wallet-snap) from 1.11.0 to 1.12.0 by updating the dependency in package.json and refreshing yarn.lock. There are no mobile source changes — only the dependency resolution and checksum for the new Snap release.

The 1.12.0 Snap release includes: a self-send warning in the send confirmation, the filled PSBT shown in the signPsbt confirmation dialog, and the new createMany account use case.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

Feature: Bitcoin wallet Snap bump

  Scenario: user uses Bitcoin account after the Snap bump
    Given the app is built from this branch
    And the user has a Bitcoin account

    When the user opens the Bitcoin account and starts a send
    Then the account balance loads and the send confirmation renders correctly
    And a self-send warning is shown when sending to the user's own address

Screenshots/Recordings

N/A — dependency bump only, no UI changes in this repo.

Before

After

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
  • I've tested with a power user scenario
  • I've instrumented key operations with Sentry traces for production performance metrics

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Note

Low Risk
Dependency-only bump with no mobile code changes; risk is limited to bundled Snap behavior for Bitcoin send, PSBT signing, and account creation flows.

Overview
Bumps the bundled @metamask/bitcoin-wallet-snap dependency from 1.11.0 to 1.12.0 in package.json and updates yarn.lock (resolution + checksum). There are no app source changes in this repo; Bitcoin UX and behavior come from the new Snap release at runtime.

Users on this build get Snap 1.12.0 behavior, including a self-send warning on send confirmation, the filled PSBT shown in signPsbt confirmation, and support for the createMany account use case.

Reviewed by Cursor Bugbot for commit a15b77a. Bugbot is set up for automated code reviews on this repo. Configure here.

@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 2, 2026
@socket-security

socket-security Bot commented Jun 2, 2026 •
edited
Loading

Copy link
Copy Markdown

Review the following changes in direct dependencies. Learn more about Socket for GitHub.

Diff Package Supply Chain
Security		 Vulnerability Quality Maintenance License
Updatednpm/​@​metamask/​bitcoin-wallet-snap@​1.11.0 ⏵ 1.12.0100 +110083 +196 +1100

View full report

@jeremytsng jeremytsng added no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed team-network-enablement labels Jun 2, 2026
@mm-token-exchange-service mm-token-exchange-service Bot removed the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 2, 2026
@codecov-commenter

codecov-commenter commented Jun 2, 2026

Copy link
Copy Markdown

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 82.77%. Comparing base (716c344) to head (4b1f9e3).
⚠️ Report is 5 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main   #30958   +/-   ##
=======================================
  Coverage   82.77%   82.77%           
=======================================
  Files        5584     5585    +1     
  Lines      144075   144108   +33     
  Branches    33332    33348   +16     
=======================================
+ Hits       119254   119291   +37     
+ Misses      16874    16868    -6     
- Partials     7947     7949    +2

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@jeremytsng jeremytsng force-pushed the chore/bump-bitcoin-wallet-snap-1.12.0 branch from 4b1f9e3 to a15b77a Compare June 4, 2026 09:54
@github-actions

github-actions Bot commented Jun 4, 2026

Copy link
Copy Markdown
Contributor

🔍 Smart E2E Test Selection

  • Selected E2E tags: SmokeSnaps
  • Selected Performance tags: None (no tests recommended)
  • Risk Level: low
  • AI Confidence: 90%
click to see 🤖 AI reasoning details

E2E Test Selection:
The only change in this PR is bumping @metamask/bitcoin-wallet-snap from 1.11.0 to 1.12.0 (a minor version bump). This snap is a preinstalled snap gated behind the bitcoin build flag, used for Bitcoin wallet keyring functionality. Key findings:

  1. No Bitcoin-specific E2E tests exist in the test suite (confirmed by searching tests/smoke/**/*.ts)
  2. The snap is imported in app/lib/snaps/preinstalled-snaps.ts and app/core/SnapKeyring/BitcoinWalletSnap.ts, both gated behind the bitcoin build flag
  3. SmokeSnaps is the appropriate tag as it covers preinstalled snap tests (test-snap-preinstalled.spec.ts) and snap lifecycle/management tests that validate snap infrastructure still works correctly after a snap version update
  4. No other tags are warranted - this is a narrow dependency bump with no impact on confirmations, accounts, networks, swaps, or other wallet features
  5. No performance impact expected from a snap version bump

Performance Test Selection:
A minor version bump of the bitcoin-wallet-snap package has no performance implications. No UI rendering, data loading, or critical user flow changes are involved.

View GitHub Actions results

@jeremytsng jeremytsng marked this pull request as ready for review June 4, 2026 10:21
@github-actions github-actions Bot added the risk:high AI analysis: high risk label Jun 4, 2026
@jeremytsng jeremytsng added this pull request to the merge queue Jun 4, 2026
Merged via the queue into main with commit b81ef07 Jun 4, 2026
265 of 296 checks passed
@jeremytsng jeremytsng deleted the chore/bump-bitcoin-wallet-snap-1.12.0 branch June 4, 2026 18:01
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 4, 2026
@metamaskbotv2 metamaskbotv2 Bot added the release-7.81.0 Issue or pull request that will be included in release 7.81.0 label Jun 4, 2026
@mm-token-exchange-service mm-token-exchange-service Bot added the INVALID-PR-TEMPLATE PR's body doesn't match template label Jun 4, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Reviewers

@Battambang Battambang Battambang approved these changes

@maxime-oe maxime-oe maxime-oe approved these changes

Assignees

No one assigned

Labels

INVALID-PR-TEMPLATE PR's body doesn't match template no-changelog no-changelog Indicates no external facing user changes, therefore no changelog documentation needed release-7.81.0 Issue or pull request that will be included in release 7.81.0 risk:high AI analysis: high risk size-XS team-network-enablement

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jeremytsng @codecov-commenter @Battambang @maxime-oe