Skip to content

ci: enable external TestFlight distribution for RC and manual builds#30952

Merged
tommasini merged 2 commits into
mainfrom
chore/external-distribution-default-rc-and-manual
Jun 2, 2026
Merged

ci: enable external TestFlight distribution for RC and manual builds#30952
tommasini merged 2 commits into
mainfrom
chore/external-distribution-default-rc-and-manual

Conversation

@tommasini

@tommasini tommasini commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

Description

RC and manual iOS builds were only uploaded to TestFlight internally (distributed to Apple internal testers only). This change enables external distribution to the MetaMask BETA & Release Candidates TestFlight group automatically for all RC build paths.

Changes:

  • runway-rc-builds.yml (Runway manual RC trigger): passes distribute_external: true to upload-to-testflight.yml so the resulting IPA is distributed to external testers immediately after upload.
  • auto-rc-ota-build-core.yml (reusable core for auto RC): adds a distribute_external input (default false to keep the interface safe for other callers) and threads it through to the inner upload-ios-testflight job.
  • build-rc-auto.yml (auto RC on release/* push): passes distribute_external: true into auto-rc-ota-build-core.yml for the iOS build job.
  • build-and-upload-to-testflight.yml (manual build + upload workflow): flips the distribute_external default to true in both the workflow_call and workflow_dispatch input blocks. The testflight_group was already defaulting to MetaMask BETA & Release Candidates.

Changelog

CHANGELOG entry: null

Related issues

Fixes:

Manual testing steps

N/A

Screenshots/Recordings

Before

N/A

After

N/A

Pre-merge author checklist

Performance checks (if applicable)

  • I've tested on Android
    • Ideally on a mid-range device; emulator is acceptable
  • I've tested with a power user scenario
    • Use these power-user SRPs to import wallets with many accounts and tokens
  • I've instrumented key operations with Sentry traces for production performance metrics

For performance guidelines and tooling, see the Performance Guide.

Pre-merge reviewer checklist

  • I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed).
  • I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots.

Made with Cursor


Note

Medium Risk
Changes release automation defaults so RC and manual iOS builds may reach external TestFlight groups without an explicit opt-in, which widens who gets builds but stays within existing upload workflows.

Overview
RC and manual iOS CI paths now turn on external TestFlight distribution by default instead of stopping at internal-only upload.

auto-rc-ota-build-core.yml gains a distribute_external workflow input and forwards it to upload-to-testflight.yml. build-rc-auto.yml and runway-rc-builds.yml set distribute_external: true on their iOS upload jobs so automated and Runway-triggered RC builds reach external testers (e.g. MetaMask BETA & Release Candidates).

build-and-upload-to-testflight.yml changes the distribute_external default from false to true for both workflow_call and workflow_dispatch, so manual build-and-upload runs distribute externally unless opted out.

Reviewed by Cursor Bugbot for commit 44989c3. Bugbot is set up for automated code reviews on this repo. Configure here.

@tommasini tommasini self-assigned this Jun 2, 2026
@github-actions

github-actions Bot commented Jun 2, 2026

Copy link
Copy Markdown
Contributor

CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes.

@mm-token-exchange-service mm-token-exchange-service Bot added the team-mobile-platform Mobile Platform team label Jun 2, 2026
@github-actions github-actions Bot added the size-S label Jun 2, 2026
@github-project-automation github-project-automation Bot moved this to Needs dev review in PR review queue Jun 2, 2026
@tommasini tommasini marked this pull request as ready for review June 2, 2026 18:38
@tommasini tommasini requested review from a team as code owners June 2, 2026 18:38
@tommasini tommasini enabled auto-merge June 2, 2026 18:38

@Cal-L Cal-L left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@github-project-automation github-project-automation Bot moved this from Needs dev review to Review finalised - Ready to be merged in PR review queue Jun 2, 2026
@github-actions github-actions Bot added the risk:medium AI analysis: medium risk label Jun 2, 2026
@tommasini tommasini added this pull request to the merge queue Jun 2, 2026
Merged via the queue into main with commit c37d99b Jun 2, 2026
110 of 111 checks passed
@tommasini tommasini deleted the chore/external-distribution-default-rc-and-manual branch June 2, 2026 19:26
@github-project-automation github-project-automation Bot moved this from Review finalised - Ready to be merged to Merged, Closed or Archived in PR review queue Jun 2, 2026
@github-actions github-actions Bot locked and limited conversation to collaborators Jun 2, 2026
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

risk:medium AI analysis: medium risk size-S team-mobile-platform Mobile Platform team

Projects

Archived in project

Development

Successfully merging this pull request may close these issues.

2 participants