chore(runway): cherry-pick fix(rewards): perps trading campaign dtos and ineligible state cp-7.80.0#30932
Merged
sleepytanya merged 4 commits intoJun 4, 2026
Conversation
Contributor
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Contributor
🔍 Smart E2E Test Selection⏭️ Smart E2E selection skipped - PR targets a release or stable branch (release/* or stable) All E2E tests pre-selected. |
sleepytanya
approved these changes
Jun 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Cherry-pick of #30907 into
release/7.80.0.Why
Sophie's fix migrates the perps leaderboard client from the old API field names (
notionalVolume,qualified) to the new ones (volume,eligible). Without this in 7.80, the shipped build would read field names that the updated backend no longer returns as primary fields — causing volume to show as a dash and every user to appear ineligible.The backend (va-mmcx-rewards#608) adds deprecated aliases to protect already-released builds, but 7.80 should ship reading the correct fields natively.
Confirmed by Christian Montoya in Slack (C09372GAN59/p1780384351113279).
Cherry-pick details
fix(rewards): perps trading campaign dtos and ineligible state)2fec6e44,d4eb4ba5,2ce386d5,a32a0283Changelog
CHANGELOG entry:
fix: perps trading campaign DTOs and ineligible state (cherry-pick of #30907)🤖 Generated with Claude Code
Note
Medium Risk
Touches rewards API mapping and user-visible eligibility/stats gating across multiple campaign screens; incorrect volume handling could hide stats or misstate qualification, but scope is limited to perps trading rewards UI and cached DTOs.
Overview
Aligns the perps trading rewards client with updated leaderboard API fields and eligibility UX for release 7.80.0 (cherry-pick of #30907).
API & state: DTOs and
RewardsControllercaching now usevolume/eligible/minVolumeForEligibility(and related position fields) instead ofnotionalVolume/qualified. Leaderboard entries exposevolume; responses includeminVolumeForEligibility.UI behavior: Stats, summary, and header components read the new fields, compute remaining volume from API threshold (with constant fallback), and guard rank/PnL/volume with
Number.isFinite. Details and leaderboard views only treat a user as having a “position” for the stats header/summary when volume is finite and > 0 (hiding stats for zero/invalid volume while rank/neighbors can still flow to the list). Leaderboard rows adapt entries for shared row UI viaqualified: true.Copy & tests: Locale strings retitle “qualify for this rank” to leaderboard qualification; tests and mocks updated across views, hooks, reducer, and controller specs, with added edge-case coverage.
Reviewed by Cursor Bugbot for commit 56eda6b. Bugbot is set up for automated code reviews on this repo. Configure here.