test: fixed issue with new modal appearing#30917
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #30917 +/- ##
========================================
Coverage 82.72% 82.72%
========================================
Files 5566 5573 +7
Lines 143286 143424 +138
Branches 33099 33145 +46
========================================
+ Hits 118529 118650 +121
- Misses 16870 16881 +11
- Partials 7887 7893 +6 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
🔍 Smart E2E Test Selection
click to see 🤖 AI reasoning detailsE2E Test Selection:
Since no Detox E2E test files or app source code were changed, no Detox E2E tags are required. The changes are purely in the Playwright/Appium performance test infrastructure. Performance Test Selection: |
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, have a team admin enable autofix in the Cursor dashboard.
Reviewed by Cursor Bugbot for commit 3fe4812. Configure here.
| testEnvironment, | ||
| ); | ||
|
|
||
| await dismissPushNotificationExistingUserSheet(); |
There was a problem hiding this comment.
Missing experience enhancer dismiss in onboarding flows
Medium Severity
loginToAppPlaywright dismisses both dismissPushNotificationExistingUserSheet and dismissExperienceEnhancerModal, but completeOnboardingPlaywright and all onboarding specs only call dismissPushNotificationExistingUserSheet. If the experience enhancer modal appears after onboarding (it's a navigation-level modal registered in App.tsx), it would block the subsequent WalletView.container visibility assertion or predict modal timer, causing test failures.
Additional Locations (2)
Reviewed by Cursor Bugbot for commit 3fe4812. Configure here.
Description
Changelog
CHANGELOG entry:
Related issues
Fixes:
Manual testing steps
Screenshots/Recordings
Before
After
Pre-merge author checklist
Performance checks (if applicable)
trace()for usage andaddTokenfor an exampleFor performance guidelines and tooling, see the Performance Guide.
Pre-merge reviewer checklist
Note
Low Risk
Changes are limited to test helpers and performance specs; no production app logic is modified.
Overview
Performance and Playwright E2E flows are updated so post-login and post-onboarding overlays no longer block navigation or skew timers.
wallet.flowadds optional-dismiss helpers for the existing-user push notification sheet and Experience Enhancer marketing modal, and calls them fromloginToAppPlaywright,onboardingFlowImportSRPPlaywright, and several onboarding performance specs after Done. Experience Enhancer and Toast page objects gain Detox/AppiumdismissIfPresent/waitForToastToDismiss(non-failing when UI is absent). Predict performance specs wait for toasts before tapping Actions; Perps add funds asserts quote readiness viaTransactionPayConfirmation.transactionFee; the multi-SRP import perf case is **skip**ped (account sync); ETH swap uses a larger test amount; seedless Android timer budgets are slightly relaxed; Predict modal dismiss reuses one button handle for the hidden wait.Reviewed by Cursor Bugbot for commit 3fe4812. Bugbot is set up for automated code reviews on this repo. Configure here.